Bitvector projection is wrong

maurer / libbap

C Bindings for BAP

1 stars 0 forks source link

Bitvector projection is wrong #2

Closed maurer closed 8 years ago

maurer commented 8 years ago

The function bap_bitvector_contents is returning incorrect values. I believe this is because Bap's Bitvector.enum_chars is buggy, and am looking into what's wrong there.

ivg commented 8 years ago

Bitvector.enum_chars is not buggy, this is a pretty printing in camlp4, see ocaml/camlp4#101.

maurer commented 8 years ago

Fixed in 0d036379e05ae268c9417e879b8a66fcd907c7f5 (problem was forgetting to call Int_val on each char), good catch with the pretty printer.