search

maurerle / eralchemy2

Entity Relation Diagrams generation tool - DEPRECATED
https://github.com/eralchemy/eralchemy
Apache License 2.0
69 stars 16 forks source link

Add type hints #7

Closed kasium closed 1 year ago

kasium commented 2 years ago

Hi, since I use mypy eralchemy2 in my projects, it would be great if eralchemy2 could add type hints. I'm happy to give a PR a try.

maurerle commented 2 years ago

Hi Kasium, sorry I did not see the notification on this. I'd be happy to see a pull request for this :)

kasium commented 2 years ago

No problem. Let me give it a try

kasium commented 2 years ago

@maurerle before I change a lot of code, what do you think about adding black and isort to the code to format it properly?

maurerle commented 2 years ago

Sure, go ahead. I don't have strong opinions on code formatting as long as it is consistent :+1:

You can then add black and isort to a [dev] extras_requires in the setup.py? That way, one can install development tools using pip install -e .[dev].

kasium commented 2 years ago