maurice-daly / DriverAutomationTool

Home of the Driver Automation Tool
https://www.msendpointmgr.com
BSD 2-Clause "Simplified" License
399 stars 120 forks source link

Can't create sccm bios package for any Lenovo Models #533

Open jeehay opened 8 months ago

jeehay commented 8 months ago

When I run the Driver automation tool it downloads the bios and extracts it and also copy the files to bios folder but it doesnt take bios package.

No errors in log file image

ThinkPad T14 Gen 2 Type 20W0 20W1   Windows 10 22H2 64 bit      20W0 20W1
TLawsonLenovo commented 6 months ago

In the path, I noticed that there is a forward slash '/' between 1.60 and 1.12. I reviewed the Lenovo catalog with our catalog team and we have changed the forward slash '/' character to be an an underscore '_' in case this is contributing to this issue.

jeehay commented 6 months ago

@TLawsonLenovo I just run the download today and its still putting the '/' in the version

jeehay commented 6 months ago

Its not just this model all T13 and T14 have same issue

TLawsonLenovo commented 6 months ago

Navigate to C:\Program Files\MSEndpointMgr\Driver Automation Tool\Temp and delete or rename the catalogv2.xml file in there. Close and reopen the tool to force a download of the latest catalogv2.xml file. You may have an old version cached in the temp folder.

jeehay commented 6 months ago

Navigate to C:\Program Files\MSEndpointMgr\Driver Automation Tool\Temp and delete or rename the catalogv2.xml file in there. Close and reopen the tool to force a download of the latest catalogv2.xml file. You may have an old version cached in the temp folder.

I cant see any xml file called catlogv2 but I have delete Temp folder but still same issue

tovo-code commented 4 months ago

Hello :) I would like to know what the status is for this issue. We do have the same problem in our enviroment. It's with the model T14 Gen 2 Type 20W0 20W1. Reloading the catalogv2 file did not help. Thanks and best regards

dgoldstein-wcpss commented 3 months ago

So looking at the code, I noticed this:

function Find-LenovoBIOS {
        param (
            [Parameter(Mandatory = $true)]
            [string]$ModelType
        )

        Set-Location -Path $global:TempDirectory
        # Download Lenovo Model Details XML
        $OS = "10"

        try {
            if ($global:ProxySettingsSet -eq $true) {
                Start-BitsTransfer -Source ($LenovoBIOSBase + $ModelType + "_Win$OS.xml") -Destination $global:TempDirectory @global:BitsProxyOptions
            } else {
                Start-BitsTransfer -Source ($LenovoBIOSBase + $ModelType + "_Win$OS.xml") -Destination $global:TempDirectory @global:BitsOptions
            }
            global:Write-LogEntry -Value "Lenovo Base - $LenovoBIOSBase, Lenovo Model Type $ModelType" -Severity 1
            global:Write-LogEntry -Value "- Quering XML $($LenovoBIOSBase + $ModelType + "_Win$OS.xml") for BIOS download links " -Severity 1
            $LenovoModelBIOSDownloads = ((Select-Xml -path ($global:TempDirectory + "\" + $ModelType + "_Win$OS.xml") -XPath "/").Node.Packages.Package | Where-Object {
                    $_.Category -match "BIOS"
                }) | Sort-Object Location -Descending | Select-Object -First 1
            Return $LenovoModelBIOSDownloads
        } catch {
            global:Write-ErrorOutput -Message "[Error] - $($_.Exception.Message)" -Severity 3
        }
    }

First off, it's hardcoding the Windows version. Second, this file no longer seems necessary for the BIOS, The catalogv2.xml that downloads for the drivers links contains the BIOS link as well.

<Model name="ThinkPad L13 Gen 5 Type 21LB 21LC">
  <Types>
   <Type>21LB</Type>
   <Type>21LC</Type>
  </Types>
  <BIOS version="1.06  (UEFI BIOS)  1.00  (ECP)" image="r2ge" crc="4309ec9055ff2eeae8b4e95878d3f0971635a981b3cbda727817e29b78acecd5">https://download.lenovo.com/pccbbs/mobiles/r2guj01w.exe</BIOS>
  <SCCM os="win10" version="21H2" crc="91084f0c2c7e4b6178067be45e77083568a5af4683164d5925ee3f58de81f3f2">https://download.lenovo.com/pccbbs/mobiles/tp_l13-gen-5_s2-gen-9_l13-2-in-1-gen-5_intel_w10_21h2_202403.exe</SCCM>
  <SCCM os="win10" version="22H2" crc="442a2eaa87b8bf5344fe0d977515af99d84f4ee5c55a62e25a51758185363e31">https://download.lenovo.com/pccbbs/mobiles/tp_l13-gen-5_s2-gen-9_l13-2-in-1-gen-5_intel_w10_22h2_202403.exe</SCCM>
  <SCCM os="win11" version="22H2" crc="03646d28bb0e7678dde54f4f2fd4468db310998b8a51eb52ecdd7c7b2929da9d">https://download.lenovo.com/pccbbs/mobiles/tp_l13-gen-5_s2-gen-9_l13-2-in-1-gen-5_intel_w11_22h2_202403.exe</SCCM>
  <SCCM os="win11" version="23H2" crc="e71a74e4df3b65a2141aea811dbfd50d3e97212a64dd81fdc69bc3f826ae5dfc">https://download.lenovo.com/pccbbs/mobiles/tp_l13-gen-5_s2-gen-9_l13-2-in-1-gen-5_intel_w11_23h2_202403.exe</SCCM>
  <HSA os="win10" version="21H2" crc="c83846588e61a9ae03a49897f46350d83d121f9088e947cd34519e7595c6959b">https://download.lenovo.com/pccbbs/mobiles/tp_l13-gen-5_s2-gen-9_l13-2-in-1-gen-5_intel_hsa_w10_21h2_202405.exe</HSA>
  <HSA os="win10" version="22H2" crc="561518b616a40d0698f133dcce494797f5ea14e1680fce51e73d204344eaaa24">https://download.lenovo.com/pccbbs/mobiles/tp_l13-gen-5_s2-gen-9_l13-2-in-1-gen-5_intel_hsa_w10_22h2_202405.exe</HSA>
  <HSA os="win11" version="22H2" crc="d50229c2441a9b9f8f3fa840a6370c666172479d58a57fbb4146527a39da5ef9">https://download.lenovo.com/pccbbs/mobiles/tp_l13-gen-5_s2-gen-9_l13-2-in-1-gen-5_intel_hsa_w11_22h2_202405.exe</HSA>
  <HSA os="win11" version="23H2" crc="9750bd1a4bcde3bf1a8aa6fa4512a52deefafda0d96254ad6901d46973f20e9c">https://download.lenovo.com/pccbbs/mobiles/tp_l13-gen-5_s2-gen-9_l13-2-in-1-gen-5_intel_hsa_w11_23h2_202405.exe</HSA>
 </Model>