search

mauriceccy / scobra

scobra - an extension of cobrapy
MIT License
6 stars 4 forks source link

Min and Max flipped in FVA #11

Open mauriceccy opened 5 years ago

mauriceccy commented 5 years ago

Min and Max values are flipped in FVA results

mauriceccy commented 5 years ago

Check the analysis/FVA code when cobra=True the order we get the fva dict is wrong? See https://github.com/opencobra/cobrapy/blob/devel/cobra/flux_analysis/variability.py We should use the column name to get the maximum and minimum value instead of the order