search

mauricedb / presentation-buddy

Automatically type code during presentations
https://marketplace.visualstudio.com/items?itemName=mauricedebeijer.presentation-buddy
MIT License
17 stars 11 forks source link

Update vscode engine and test runners #18

Closed dylanbeattie closed 7 months ago

dylanbeattie commented 8 months ago

This updates the vscode engine to 1.87.0, the TypeScript compiler target to ES2022, and replaces the old Mocha test runner with the new VS Code test runner.

(Presentation Buddy is awesome and I'm working on a new feature for it, which needed a working test runner to figure out some parsing things. I'm happy to build off my own fork if this PR is going to break your publishing flow or anything but figured I'd open the PR and see what you thought!)

mauricedb commented 8 months ago

Cool, I really appreciate the pr. I am a little bit busy at the moment but will review and get back to you as soon as possible.

dylanbeattie commented 7 months ago

So the actual feature I propose to add is implemented here:

https://github.com/dylanbeattie/presentation-buddy/pull/1

(I haven't opened a PR for this one yet because until the tooling PR is merged, the diffs between my branch and the upstream master are a bit of a mess)

Notes on what it adds (and how it works) are in the README - take a look, I'd love to know whether you think this is a useful addition to Presentation Buddy or if you'd prefer I spin it off as a new extension.

Thanks 😊

mauricedb commented 7 months ago

Hi Dylan,

I was just looking at the typeChunksFromFile instruction you are proposing and I like that way it works. Looks like that will make it much easier to use with a large amount of input where you want additional pauses, something I do quite often.

I would probably not have added the special case for the waitAfterNewLine as it looks like it could just as easily be included in the waitAfterTyping array but I don't have an issue with it either.

I would be delighted to include this PR.

Thank, Maurice

Maurice de Beijer ABL – The Problem Solver Microsoft MVP www.TheProblemSolver.nl www.twitter.com/mauricedb

On Thu, Mar 21, 2024 at 12:43 PM Dylan Beattie @.***> wrote:

So the actual feature I propose to add is implemented here:

dylanbeattie#1 https://github.com/dylanbeattie/presentation-buddy/pull/1

(I haven't opened a PR for this one yet because until the tooling PR is merged, the diffs between my branch and the upstream master are a bit of a mess)

Notes on what it adds (and how it works) are in the README - take a look, I'd love to know whether you think this is a useful addition to Presentation Buddy or if you'd prefer I spin it off as a new extension.

Thanks 😊

— Reply to this email directly, view it on GitHub https://github.com/mauricedb/presentation-buddy/pull/18#issuecomment-2012050033, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYMWIX7DRQI25O6MW7HWFDYZLBXTAVCNFSM6AAAAABE4ENNOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJSGA2TAMBTGM . You are receiving this because you commented.Message ID: @.***>

dylanbeattie commented 7 months ago

Hey Maurice,

There are two reasons I plugged in WaitAfterNewLine as a special case. First, having used this for a week or so I didn't actually find any scenario or language where I didn't want that option, so having it enabled by default seemed like a good idea.

Second: the VS Code configuration editor for string arrays can't cope with literal newlines - if you put a \n in the JSON config, it shows as an empty string in the config editor, and if you enter a \n in the config editor UI it's persisted as \\n in the JSON.

I agree it would make more sense as just another entry in the array, but after playing around with it I decided the tooling made this more confusing than having an extra config setting - let me know what you think.

mauricedb commented 7 months ago

Hey Maurice,

There are two reasons I plugged in WaitAfterNewLine as a special case. First, having used this for a week or so I didn't actually find any scenario or language where I didn't want that option, so having it enabled by default seemed like a good idea.

Second: the VS Code configuration editor for string arrays can't cope with literal newlines - if you put a \n in the JSON config, it shows as an empty string in the config editor, and if you enter a \n in the config editor UI it's persisted as \\n in the JSON.

I agree it would make more sense as just another entry in the array, but after playing around with it I decided the tooling made this more confusing than having an extra config setting - let me know what you think.

👍 Right makes total sense.

Just leave it as is then and I will be happy to merge this when you create the second PR.