mauricelam / genny

Elegant generics for Go
MIT License
24 stars 6 forks source link

Fixed: types in function calls not capitalizing & unexported types not being replaced #6

Closed sh-ura closed 4 years ago

mauricelam commented 6 years ago

The differences in the test case doesn't look quite right. "Int" part in DiagraphInt should still be capitalized, right?

https://travis-ci.org/mauricelam/genny/jobs/416080197

--- Expected
+++ Actual

-func NewDigraphInt() *DigraphInt {
-   return &DigraphInt{
-       nodes: make(map[int][]int),
+func NewDigraphInt() *Digraphint {
+   return &Digraphint{
+       ints: make(map[int][]int),
    }
sh-ura commented 6 years ago

Hi, I think I fixed that bug on my end but forgot to push to this PR, I'll push it later tonight.

On Mon, Sep 3, 2018, 5:50 PM Maurice Lam, notifications@github.com wrote:

The differences in the test case doesn't look quite right. "Int" part in DiagraphInt should still be capitalized, right?

https://travis-ci.org/mauricelam/genny/jobs/416080197

-func NewDigraphInt() *DigraphInt {

  • return &DigraphInt{
  • nodes: make(map[int][]int), +func NewDigraphInt() *Digraphint {
  • return &Digraphint{
  • ints: make(map[int][]int), }

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mauricelam/genny/pull/6#issuecomment-418197147, or mute the thread https://github.com/notifications/unsubscribe-auth/ASZiuh10FXsa8vKTDPzllz2Qf9x5Trtmks5uXaQMgaJpZM4V9FyK .