mauricelam / genny

Elegant generics for Go
MIT License
24 stars 6 forks source link

Case insensitive matching when replacing types causes issues #7

Open tobgu opened 6 years ago

tobgu commented 6 years ago

I have a generic package with a type called dataType for which I use github.com/mauricelam/genny to generate specific implementations. The problem is that in the same file there are also calls to a method called DataType. This has previously not caused any issues but now fails to compile because that method name is replaced with a specific type (eg. int, bool, etc.).

This is the change that caused the issues for me: https://github.com/mauricelam/genny/commit/eb2c5232c885956af3565a20ecf48555cab2b9bc#diff-85371fdabae4611287ecb7f38e19a87bR643

Is there any particular reason to make the comparison case insensitive?

The following line now gives a compilation error for example: https://github.com/tobgu/qframe/blob/master/internal/template/column.go#L41

This is what the error looks like: https://travis-ci.org/tobgu/qframe/builds/426205897