mauricerenck / komments

A Kirby comment plugin
MIT License
44 stars 8 forks source link

Labels not visible with 1.7.0 #45

Closed MaluNoPeleke closed 2 years ago

MaluNoPeleke commented 2 years ago

On my production site I have komments 1.6.0 installed which works and looks great: image With an upgrade to 1.7.0 on my development environment all the labels are gone (also in the source code): image I haven't changed the paths of the integration or the template code. What could be the issue?

mauricerenck commented 2 years ago

Hi,

the latest release was only a sort of deprecation release, I removed functions like sending webmentions. The snippets or translations didn't change. Do you use your own translations? Maybe there is something wrong there?

MaluNoPeleke commented 2 years ago

Hmm, I haven't touched that. The integration looks like this:

    <p class="font-semibold text-2xl"><?php echo t('Comments', 'Kommentare') ?></p>
    <a class="font-medium text-xl text-center py-2" href="#kommentform"><?php echo t('Comment', 'Jetzt kommentieren ⬇️') ?></a>
    <?php
     snippet('komments/webmention-splitted');
     snippet('komments/kommentform'); 
    ?>
    </div>

Header:

<?= Bnomei\Fingerprint::css('/media/plugins/mauricerenck/komments/komments.css'); ?>

The config like this:

    'mauricerenck' => [
      'komments' => [
          'auto-delete-spam' => false,
          'send-mention-on-update' => false,
          'notifications' => [
              'email' => [
                  'enable' => true,
                  'sender' => 'email@gmail.com',
                  'emailReceiverList' => ['email@domain.tld'],
              ]
          ]
      ],
      'indieConnector' => [
        'secret' => 'mysecrethere',
        'stats' => true,
        'sqlitePath' => 'site/logs/'
      ]
    ],

languages/de.php:

<?php

return [
    'code' => 'de',
    'default' => true,
    'direction' => 'ltr',
    'locale' => [
        'LC_ALL' => 'de_DE'
    ],
    'name' => 'Deutsch',
    'translations' => [

    ],
    'url' => NULL
];

languages/en.php:

<?php

return [
    'code' => 'en',
    'default' => false,
    'direction' => 'ltr',
    'locale' => [
        'LC_ALL' => 'en_US'
    ],
    'name' => 'English',
    'translations' => [
        'Search' => 'Search…',
        'searchresults' => 'Search results',
        'Follow' => 'Follow',
        'by' => 'By',
        'publishedat' => 'published at',
        'readmore' => 'Read more…',
        'nextpost' => 'Next post',
        'previouspost' => 'Previous post',
        'aboutme' => 'About me',
        'aboutmeinfo' => 'About me',
        'moreaboutme' => 'More about me',
        'featured' => 'Featured posts',
        'latest' => 'Latest posts',
        'similar' => 'Similar posts',
        'Comments' => 'Comments',
        'Comment', 'Jetzt kommentieren ⬇️'
    ],
    'url' => NULL
];
MaluNoPeleke commented 2 years ago

I forgot that I am using a customized snippets/komments/type/reply.php file in combination with Tailwind Typography plugin:

<li class="single-komment komment-type-<?php echo strtolower($komment['kommenttype']); ?> <?php echo ($komment['verified'] == 'true') ? 'verified' : ''?>" id="komment_<?php echo $komment['id']; ?>">
    <div class="author-avatar text-center">
        <a href="<?php echo $komment['authorurl']; ?>" rel="nofollow" target="_blank">
            <img src="<?php echo $komment['avatar']; ?>" alt="<?php echo $komment['author']; ?>">
        </a>
        </br>  
        <span><?php echo option('mauricerenck.komments.komment-icon-reply'); ?></span>
    </div>
    <div class="author-action">
        <?php if ($komment['verified'] == 'true') : ?><span class="verified-badge"><?php echo option('mauricerenck.komments.komment-icon-verified', '✅'); ?></span><?php endif; ?>
        <a href="<?php echo $komment['authorurl']; ?>" rel="nofollow" target="_blank"><?php echo $komment['author']; ?></a>&nbsp;
        <span class="replyHandleDisplay"></span>
        <!--<?php echo t('mauricerenck.komments.replied'); ?>-->
    </div>
    <div class="mention-content">
        <?php if ($komment['quote']->quote()->isNotEmpty()): ?>
            <div class="quote"><p class="prose"><?php echo $komment['quote']->quote()->html(); ?></p></div>
        <?php endif; ?>
        <?php if ($komment['komment']->komment()->isNotEmpty()): ?>
            <div class="komment-text prose">

                <?php echo $komment['komment']->komment()->kirbytext(); ?>
            </div>
        <?php endif; ?>
        <a href="#kommentform" class="kommentReply <?php echo option('mauricerenck.komments.replyClassNames'); ?>" data-id="<?php echo $komment['id']; ?>" data-handle="<?php echo $komment['author']; ?>"><span class="date float-left text-gray-500 font-light"><?php echo "(" . $komment['published']->published()->toDate('%d.%m.%Y %H:%M') . ")"; ?></span><?php echo "↩️ " . t('mauricerenck.komments.action.reply.text'); ?></a>
    </div>
</li>

But if I rename it the issue still remains, so this doesn't seem to be a reason for this behaviour.

mauricerenck commented 2 years ago

The reply snippet shouldn't change anything in the form. Do you see any other translations? Could it be that the empty translations array in your german language file is a cause for that? Do you see the translation when viewing the english version?

MaluNoPeleke commented 2 years ago

Sent you an email about it, maybe it can be solved easier this way.