fix thank you message translation

mauricerenck / komments

A Kirby comment plugin

MIT License

44 stars 8 forks source link

fix thank you message translation #59

Closed hariom147 closed 12 months ago

hariom147 commented 1 year ago

currently the mauricerenck.komments.thankyou message is always shown in the default language, no matter what the current language is. maybe related to t() helper not working in this context.

fix by using I18n::template() instead.

Bildschirmfoto 2023-09-18 um 08 46 57

mauricerenck commented 12 months ago

Thank you for that fix :) I am not quite sure if ::template() or :: translate() is the right solution here. Why did you choose template()?

hariom147 commented 12 months ago

you are right, ::template isn't needed here, as there are no placeholders to replace. Updated the PR.

mauricerenck commented 12 months ago

:tada: This PR is included in version 1.12.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: