mauricerenck / komments

A Kirby comment plugin
MIT License
45 stars 8 forks source link

Compatibility issue with indieConnector v2.1.1? #68

Closed srijan closed 2 months ago

srijan commented 2 months ago

I get this error when getting an indieweb reply:

<code>Error: Call to a member function kommentsInbox() on string
#18 /var/www/html/site/plugins/komments/utils/receiveKomment.php(14): mauricerenck\Komments\KommentReceiver::storeData
#17 /var/www/html/site/plugins/komments/components/hooks.php(28): Kirby\Cms\App::mauricerenck\Komments\{closure}
#16 [internal](0): Closure::call
#15 /var/www/html/vendor/getkirby/cms/src/Toolkit/Controller.php(60): Kirby\Toolkit\Controller::call
#14 /var/www/html/vendor/getkirby/cms/src/Cms/Event.php(139): Kirby\Cms\Event::call
#13 /var/www/html/vendor/getkirby/cms/src/Cms/App.php(1645): Kirby\Cms\App::trigger
#12 /var/www/html/site/plugins/indieconnector/lib/WebmentionReceiver.php(119): mauricerenck\IndieConnector\WebmentionReceiver::triggerWebmentionHook
#11 /var/www/html/site/plugins/indieconnector/lib/WebmentionReceiver.php(46): mauricerenck\IndieConnector\WebmentionReceiver::processWebmention
#10 /var/www/html/site/plugins/indieconnector/plugin/hooks.php(55): Kirby\Cms\App::mauricerenck\IndieConnector\{closure}
#9 [internal](0): Closure::call
#8 /var/www/html/vendor/getkirby/cms/src/Toolkit/Controller.php(60): Kirby\Toolkit\Controller::call
#7 /var/www/html/vendor/getkirby/cms/src/Cms/Event.php(139): Kirby\Cms\Event::call
#6 /var/www/html/vendor/getkirby/cms/src/Cms/App.php(1645): Kirby\Cms\App::trigger
#5 /var/www/html/site/plugins/indieconnector/plugin/routes.php(37): Kirby\Http\Route::mauricerenck\IndieConnector\{closure}
#4 [internal](0): Closure::call
#3 /var/www/html/vendor/getkirby/cms/src/Http/Router.php(120): Kirby\Http\Router::call
#2 /var/www/html/vendor/getkirby/cms/src/Cms/App.php(338): Kirby\Cms\App::call
#1 /var/www/html/vendor/getkirby/cms/src/Cms/App.php(1191): Kirby\Cms\App::render
#0 /index.php(18): null</code>

I see a change in indieConnector v2.1.1: "webmention now sends uuid instead of page object (ee93c5d)".

To confirm, I tried it with this commit reverted, and it works.

Does komments need a new release to be compatible with indieConnector v2.1.1?

(Originally published at: https://srijan.ch/notes/2024-09-01-001)

mauricerenck commented 2 months ago

:tada: This issue has been resolved in version 2.1.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: