search

mauricevancooten / react-anchor-link-smooth-scroll

React component for anchor links using the smooth scroll polyfill.
243 stars 31 forks source link

Remove offset prop from being spread on the <a /> element #11

Closed ericmasiello closed 6 years ago

ericmasiello commented 6 years ago

In the current implementation, all props are being spread across the <a /> element. This triggers React to throw a warning saying the offset property is not valid. This change destructures the offset property in the render method and then spreads all remaining props (including children) across the <a /> element.

mauricevancooten commented 6 years ago

Thanks for fixing the issue. I have merged your request and updated NPM to the new version.