search

mauricioklein / docker-compose-api

A Docker Compose parser for Ruby
MIT License
33 stars 25 forks source link

Correctly parses volumes from the compose file and set binds when creating the container #15

Closed jeroenj closed 8 years ago

jeroenj commented 8 years ago

Before this change volumes from the compose yml were send directly to the API in an array structure while it actually expects a Hash.

In order to be able to bind volumes to the host's local filesystem they should be passed through the ['HostConfig']['Binds'] attribute in the API.

jeroenj commented 8 years ago

Upon further investigation it appears that volumes isn't needed when creating the container. However it needs to be passed when starting a container. Working on that right now.

jeroenj commented 8 years ago

There were some issues with my first commit. I've fixed all of those and squashed my commits.

mauricioklein commented 8 years ago

Outsanding job @jeroenj ! Thanks for contributing! Merging...