search

mauricioklein / docker-compose-api

A Docker Compose parser for Ruby
MIT License
33 stars 25 forks source link

Loosens the docker dependency to ~> 1.22 #20

Closed jeroenj closed 8 years ago

jeroenj commented 8 years ago

I've been using v1.26 for the past week and everything works as expected. All tests also still pass.

Was there any reason for this strict locking? I think it will be safe to support all v1.x versions of docker-api. If not I'd lock to minor releases instead of a fixed release.

mauricioklein commented 8 years ago

No, I've changed it to ensure the Docker API version. i've heard of some problems of backward compatibility of API version, so It's safer to use an specific version. But, since you had problems with this modification, it's quietly possible that others will have to, so we can keep a loose minor version. Sorry about the problem....

jeroenj commented 8 years ago

Thanks, an no worries. :+1:

If an incompatibility ever comes up in a minor release you can use ~> 1.22, < 1.26 in the gemspec to avoid installing a more recent - breaking - version.

mauricioklein commented 8 years ago

Perfect! I'll keep that in mind... Thanks for the suggestion :+1: