search

mauricioklein / docker-compose-api

A Docker Compose parser for Ruby
MIT License
33 stars 25 forks source link

Add Basic Support for V2 Docker-Compose Configs #26

Closed apeschel closed 8 years ago

apeschel commented 8 years ago

This commit adds support for V2 docker-compose configs. It does not add any functionality included in the new style of config. Specifically, it does not add functionality for the new Volume or Network entries. It also doesn't handle the fact that some keys have had their positions in the config tree moved.

zuazo commented 8 years ago

Travis error:

1) DockerCompose Without memory should be able to access gem version
   Failure/Error: config = DockerComposeConfig.new(filepath)

   NameError:
     uninitialized constant DockerCompose::DockerComposeConfig
   # ./lib/docker-compose.rb:26:in `load'
   # ./spec/docker-compose/docker_compose_spec.rb:6:in `block (3 levels) in <top (required)>'

I am not responsible for this gem. But in addition to fix that error, I think you should add some tests. See the spec/ directory.

Related issue: https://github.com/mauricioklein/docker-compose-api/issues/21

apeschel commented 8 years ago

@zuazo Thanks for the advice! I've corrected the issues and added tests for the new code.

mauricioklein commented 8 years ago

Outstanding job folks. Thanks for the contribution. Merging and generating a new release soon...