mauricioklein / docker-compose-api

A Docker Compose parser for Ruby
MIT License
33 stars 25 forks source link

Fix image format to work with repo's port #34

Closed bazilio91 closed 5 years ago

mauricioklein commented 5 years ago

Hello @bazilio91 !

First of all, sorry for the looong time until a reply. I decided to resume this project after a couple of years and your PR for sure is a great improvement.

So, my question is if you're still interested in merging the PR? If so, could you please fix the broken spec? After that, we should be good to go.

If you're not interested anymore, I totally understand, and please accept my excuses anyway.

Thanks in advance!

bazilio91 commented 5 years ago

Looks like failed tests are not related to this PR

mauricioklein commented 5 years ago

You're right. It's a flickering test, and I'll take care of that in a different PR. For now, I triggered a rebuild on your branch and it's green. I'm merging your PR. Thanks for contributing! 👍