search

mauricioklein / docker-compose-api

A Docker Compose parser for Ruby
MIT License
33 stars 25 forks source link

Add SecureRandom requirement to avoid NameError #8

Closed gabriellhrn closed 8 years ago

gabriellhrn commented 8 years ago

The model compose_container.rb uses a module that was not required before.

I got an error while trying to create a container which was fixed after adding the require.

$ ruby test.rb
Starting containers ...
/usr/local/lib/ruby/gems/2.2.0/gems/docker-compose-api-1.0.1/lib/docker-compose/models/compose_container.rb:44:in `prepare_image': uninitialized constant ComposeContainer::SecureRandom (NameError)
    from /usr/local/lib/ruby/gems/2.2.0/gems/docker-compose-api-1.0.1/lib/docker-compose/models/compose_container.rb:127:in `start'
    from /usr/local/lib/ruby/gems/2.2.0/gems/docker-compose-api-1.0.1/lib/docker-compose/models/compose.rb:81:in `block in call_container_method'
    from /usr/local/lib/ruby/gems/2.2.0/gems/docker-compose-api-1.0.1/lib/docker-compose/models/compose.rb:80:in `each'
    from /usr/local/lib/ruby/gems/2.2.0/gems/docker-compose-api-1.0.1/lib/docker-compose/models/compose.rb:80:in `call_container_method'
    from /usr/local/lib/ruby/gems/2.2.0/gems/docker-compose-api-1.0.1/lib/docker-compose/models/compose.rb:46:in `start'
    from test.rb:42:in `<main>'
$ vim /usr/local/lib/ruby/gems/2.2.0/gems/docker-compose-api-1.0.1/lib/docker-compose/models/compose_container.rb
$ ruby test.rb
Starting containers ...
true
$
mauricioklein commented 8 years ago

Thanks for your contribution @gabriellhrn !

PR merged.