mauriciopoppe
commented
5 months ago Thank you for noticing this issue, I’m on vacation until the end of the month, I’ll take a look in February.
Best, Mauricio
On Thu, Jan 18, 2024 at 11:25 PM Jorin @.***> wrote:
Hello! I was trying to build the package from main to resolve an issue in my codebase seemingly related to #270 https://github.com/mauriciopoppe/function-plot/issues/270. I ran the following after checkout:
- npm install
- npm run build
- npm pack
To build the project. This produces the following pack list:
npm notice npm notice 📦 @.*** npm notice === Tarball Contents === npm notice 1.1kB LICENSE npm notice 3.0kB README.md npm notice 42.4kB dist/117.function-plot.js npm notice 64.5kB dist/117.function-plot.js.map npm notice 3.8kB dist/asyncIntervalEvaluator.function-plot.js npm notice 7.6kB dist/asyncIntervalEvaluator.function-plot.js.map npm notice 26.4kB dist/chart.js npm notice 22.8kB dist/chart.js.map npm notice 607B dist/datum-defaults.js npm notice 577B dist/datum-defaults.js.map npm notice 2.6kB dist/evaluate-datum.js npm notice 2.5kB dist/evaluate-datum.js.map npm notice 1.9kB dist/evaluate-datum.test.js npm notice 3.3kB dist/evaluate-datum.test.js.map npm notice 138.1kB dist/function-plot.js npm notice 234.0kB dist/function-plot.js.map npm notice 1.2kB dist/globals.mjs npm notice 1.1kB dist/globals.mjs.map npm notice 221B dist/graph-types/index.js npm notice 300B dist/graph-types/index.js.map npm notice 4.1kB dist/graph-types/interval.js npm notice 4.1kB dist/graph-types/interval.js.map npm notice 3.3kB dist/graph-types/polyline.js npm notice 3.1kB dist/graph-types/polyline.js.map npm notice 2.2kB dist/graph-types/scatter.js npm notice 2.2kB dist/graph-types/scatter.js.map npm notice 1.4kB dist/graph-types/text.js npm notice 1.6kB dist/graph-types/text.js.map npm notice 44B dist/graph-types/types.js npm notice 117B dist/graph-types/types.js.map npm notice 3.0kB dist/helpers/annotations.js npm notice 3.1kB dist/helpers/annotations.js.map npm notice 2.6kB dist/helpers/derivative.js npm notice 2.4kB dist/helpers/derivative.js.map npm notice 425B dist/helpers/index.js npm notice 538B dist/helpers/index.js.map npm notice 3.0kB dist/helpers/secant.js npm notice 3.2kB dist/helpers/secant.js.map npm notice 2.0kB dist/index.js npm notice 1.6kB dist/index.js.map npm notice 3.7kB dist/perf/interval-pipeline.js npm notice 3.6kB dist/perf/interval-pipeline.js.map npm notice 87B dist/plugins/index.js npm notice 173B dist/plugins/index.js.map npm notice 3.0kB dist/plugins/zoom-box.js npm notice 2.9kB dist/plugins/zoom-box.js.map npm notice 2.0kB dist/polyfills.js npm notice 1.2kB dist/polyfills.js.map npm notice 6.2kB dist/samplers/builtIn.js npm notice 6.6kB dist/samplers/builtIn.js.map npm notice 7.4kB dist/samplers/builtIn.test.js npm notice 7.9kB dist/samplers/builtIn.test.js.map npm notice 3.6kB dist/samplers/eval.mjs npm notice 2.4kB dist/samplers/eval.mjs.map npm notice 207B dist/samplers/index.js npm notice 253B dist/samplers/index.js.map npm notice 4.9kB dist/samplers/interval_worker_pool.js npm notice 4.5kB dist/samplers/interval_worker_pool.js.map npm notice 7.2kB dist/samplers/interval.js npm notice 8.7kB dist/samplers/interval.js.map npm notice 5.0kB dist/samplers/interval.test.js npm notice 5.0kB dist/samplers/interval.test.js.map npm notice 44B dist/samplers/types.js npm notice 114B dist/samplers/types.js.map npm notice 5.8kB dist/tip.js npm notice 6.1kB dist/tip.js.map npm notice 44B dist/types.js npm notice 102B dist/types.js.map npm notice 2.4kB dist/utils.mjs npm notice 3.2kB dist/utils.mjs.map npm notice 2.6kB dist/utils.test.js npm notice 3.2kB dist/utils.test.js.map npm notice 3.9kB package.json npm notice === Tarball Details === npm notice name: function-plot npm notice version: 1.24.0 npm notice filename: function-plot-1.24.0.tgz npm notice package size: 199.4 kB npm notice unpacked size: 716.0 kB npm notice shasum: 2a7d24bbdfd48d480f683bc7b4d32e9342981695 npm notice integrity: sha512-jJUmyx0UQZnhH[...]7r5NbpmxewDEw== npm notice total files: 73 npm notice
Notably missing are declaration files. After some looking around I noticed that "declaration": true has been removed https://github.com/mauriciopoppe/function-plot/compare/release-1.24...master#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0L10 from tsconfig.json since 1.24. Re-adding declaration to tsconfig.json seems to fix this, although I'm having some other problems that are getting in the way of verifying the fix.
— Reply to this email directly, view it on GitHub https://github.com/mauriciopoppe/function-plot/issues/273, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMKWKWNHJKM3T3FCJBIT4LYPGONFAVCNFSM6AAAAABCBAS2MOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DSMJVGI4DMMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
annieetang
jorins
Hello! I was trying to build the package from
mainto resolve an issue in my codebase seemingly related to #270. I ran the following after checkout:npm installnpm run buildnpm packTo build the project. This produces the following pack list:
Notably missing are declaration files. After some looking around I noticed that
"declaration": truehas been removed fromtsconfig.jsonsince 1.24. Re-addingdeclarationtotsconfig.jsonseems to fix this, although I'm having some other problems that are getting in the way of verifying the fix.