mauriciorodrigues / memcached-session-manager

Automatically exported from code.google.com/p/memcached-session-manager
0 stars 0 forks source link

Session cookie name is hardcoded to JSESSIONID #65

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
memcached-session-manager sets a new session cookie when the memcached node 
containing this session changed. The cookie name is hard coded to JSESSIONID. 
At least tomcat7 provides the ApplicationSessionCookieConfig with 
getSessionCookieName, and the session cookie name seems to be overridable for a 
context.

Original issue reported on code.google.com by martin.grotzke on 17 Nov 2010 at 12:25

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Fixed.

Setting the session cookie / changing the session id is now delegated to 
o.a.catalina.connector.Request.changeSessionId(String sessionId). This is 
available since 6.0.21!

So any new version of msm now requires tomcat >= 6.0.21.

However, reading the configured session cookie name is still relevant, as we 
check for a session cookie during session backup. For this the correct session 
cookie name has to be used.

Since tc 6.0.27/28 the session cookie name is configurable per context (see 
http://tomcat.apache.org/tomcat-6.0-doc/changelog.html and 
http://issues.apache.org/bugzilla/show_bug.cgi?id=48379).
The sessionCookieName is read from the context if this method is available, 
otherwise (for earlier versions) the Globals.SESSION_COOKIE_NAME is used 
(configurable via system property org.apache.catalina.SESSION_COOKIE_NAME).

Original comment by martin.grotzke on 28 Dec 2010 at 10:30

GoogleCodeExporter commented 8 years ago

Original comment by martin.grotzke on 27 Jan 2011 at 10:36