search

mauricioszabo / atom-chlorine

An Atom plugin to integrate with Socket-REPL over Clojure, ClojureScript, ClojureCLR, Joker, Babashka, Clojerl, Lumo and Plank
MIT License
176 stars 17 forks source link

shadow-cljs.edn redundant about source-paths / dependencies? #39

Closed sogaiu closed 5 years ago

sogaiu commented 5 years ago

I was looking at the Shadow CLJS User's Guide and noticed this text in section 3.2.1. (regarding Leiningen):

If you’d like to use Leiningen for your build system (particularly if you use Cursive), the shadow-cljs command-line utility can be configured to use lein to run your commands. Enable this by adding a :lein entry to your shadow-cljs.edn config. With this setting, the shadow-cljs command will use lein to launch the JVM, ignoring any :source-paths and :dependencies in shadow-cljs.edn; relying instead on lein to set them from project.clj.

atom-chlorine's shadow-cljs.edn currently appears to have :lein true -- but it also specifies :source-paths and :dependencies in the same file.

Please explain the intent of the current configuration as it seems confusing.

(This came up because I was attempting to get binaryage/(cljs-)devtools to work and it wasn't clear where to put the dependencies. I tried adding it as a dependency in a few locations without ultimate success.)

mauricioszabo commented 5 years ago

Yes, it's confusing right now. In the beginning, I used shadow-cljs only but then I found errors when trying to put the "UNREPL" blob, so now I'm just using lein. You can even delete :source-paths and :dependencies from shadow-cljs.edn and see if works, if so, please send me a PR :).

I'll probably fix these confusing issues as soon as possible :)