search

mauriciovigolo / keycloak-angular

Easy Keycloak setup for Angular applications.
MIT License
730 stars 280 forks source link

Disable analytics #461

Closed XhmikosR closed 1 year ago

XhmikosR commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

jonkoops commented 1 year ago

Since this PR includes no motivation why we should be doing this I am going to go ahead and close it. I also see no problem providing the Angular team with analytics in the first place.

XhmikosR commented 1 year ago

The reason I added it is because angular.json is modified every time without an option set. You can go with true or whatever, as long as the file is not modified locally.