search

mauroc / squiddio_pi

squiddio_pi
3 stars 13 forks source link

Preference Issues which need fixing #134

Closed rgleason closed 3 years ago

rgleason commented 4 years ago

Please see this comment and below https://github.com/OpenCPN/plugins/pull/254#issuecomment-702257057

Tested on Windows, Android, and Ubuntu 18.04 and found the same/similar small issues:

  1. Can we get the preferences screen in Android to be the full screen?
  2. When the POI's are OpenCPN waypoints that the text stays on no matter what the "Text on" setting is. So this is a universal problem. When ODraw Textpoints are being used this is not a problem.
  3. Android bouys (weather) and AIS not working when checked. However in the Windows version 1.3.10.0 I found that the bouys are working when both OpenCPN waypoints and ODraw Textpoints are used, so this is some problem caused by Android not accepting the way things are coded.
rgleason commented 4 years ago

In squiddioprefsDialogBase.cpp Line 66-85 I believe something is amiss. Since it is handled by formbuilder I am not going to mess with this. 

    sbDestSizer->Add( viewDestinations, 1, wxEXPAND, 5 );

    wxStaticBoxSizer* sbSizer61;
    sbSizer61 = new wxStaticBoxSizer( new wxStaticBox( sbDestSizer->GetStaticBox(), wxID_ANY, _("Cruising Aids") ), wxVERTICAL );

    m_checkBoxNDBC = new wxCheckBox( sbSizer61->GetStaticBox(), wxID_ANY, _("NDBC Buoy Reports"), wxDefaultPosition, wxDefaultSize, 0 );
    m_checkBoxNDBC->SetToolTip( _("Get quasi-real time wind, wave and pressure report from thousands of NDBC buoys right from your chart.") );

    sbSizer61->Add( m_checkBoxNDBC, 0, wxALL, 5 );

    m_checkBoxShipRep = new wxCheckBox( sbSizer61->GetStaticBox(), wxID_ANY, _("NDBC Ship Reports"), wxDefaultPosition, wxDefaultSize, 0 );
    m_checkBoxShipRep->SetToolTip( _("Get quasi-real time wind, wave and pressure report from participating NDBC ships right from your chart.") );

    sbSizer61->Add( m_checkBoxShipRep, 0, wxALL, 5 );

    m_checkBoxAIS = new wxCheckBox( sbSizer61->GetStaticBox(), wxID_ANY, _("AIS markers"), wxDefaultPosition, wxDefaultSize, 0 );
    sbSizer61->Add( m_checkBoxAIS, 0, wxALL, 5 );

    sbDestSizer->Add( sbSizer61, 1, wxEXPAND, 5 );
rgleason commented 3 years ago

Mauro, these problems seem to have been fixed. I would check them and then close this if you are satisfied.

rgleason commented 3 years ago

https://github.com/mauroc/squiddio_pi/pull/133