search

mauroc / squiddio_pi

squiddio_pi
3 stars 13 forks source link

ci: circleci, appveyor: Only deploy on master branch (#52). #53

Closed leamas closed 5 years ago

leamas commented 5 years ago

Closes #52 so that PR builds successfully without making a failed deployment attempt.

mauroc commented 5 years ago

@leamas question: will the PR not make it impossible to test build/deploy on a branch before merging it with master? For instance, I did all my testing on your reset35 branch yesterday by git pushing to the branch, not master. Only when everything worked did I merge the branch with master

leamas commented 5 years ago

will the PR not make it impossible to test build/deploy on a branch before merging it with master?

Sort of. But it won't work anyway for a random PR because that code doesn't have access to the deployment key. So that testing must be done by you, owner of one key to rule them all. This is also the strategy already used by travis.yml.

For you, it doesn't make that big a difference. You could just comment out the checks in {appveyor, circleci}-upload.sh while testing.