search

mauroc / squiddio_pi

squiddio_pi
3 stars 13 forks source link

Cmake changes #60

Closed jongough closed 4 years ago

leamas commented 4 years ago

Just a drive-by comment: I saw that you basically do INCLUDE(CPack) before setting the CPACK_* variables. This will not fly, CPack only sees the variables defined when it is included.

Besides: this effort to clean up the mess is really, really nice...

rgleason commented 4 years ago

As is all of your work Alec! Thanks to all of you. This is a great improvement.

mauroc commented 4 years ago

travis macos build appears stuck indefinitely - merging PR nevertheless

jongough commented 4 years ago

INCLUDE(CPack) is the last statement in PluginPackage.cmake after all the CPACK_** variables have been set. Where did you see that was not the case?

leamas commented 4 years ago

INCLUDE(CPack) is the last statement in PluginPackage.cmake

Indeed

Where did you see that was not the case?

I failed to read a patch... sorry for the noise.