search

mauroc / squiddio_pi

squiddio_pi
3 stars 13 forks source link

,EXE name convention is missing "ov50" for tagged push to github release #65

Closed rgleason closed 4 years ago

rgleason commented 4 years ago

In We've been using this form "squiddio_1.0.10-ov50_win32.exe" and it has been helpful to users.

adding this makes prefix which makes some sense for circleci deploy: opencpn-plugin-squiddio_1.0.10-ov50_win32.exe

now github release seems to be this format squiddio_pi-1.0.17.1_msvc-10.0.14393.exe

Please explain, if the last number was the Plugin API that might be ok.

MacOS is showing as Squiddio-Plugin_1.0.17-ov50-1.16.pkg

rgleason commented 4 years ago

For Alec's Plugin Manager, the minimum ocpn version is automatically dealt with, however git release is dependent on manual install by the user, so "ov50" is very helpful.

rgleason commented 4 years ago

For MacOS in buildosx/installos/squiddio_pi.pkgproj.in and for other plugiins

  1. About Line 1450 the plugin name is handled very nicely.
        <key>NAME</key>
            <string>${VERBOSE_NAME}-Plugin_${PACKAGE_VERSION}-${OCPN_MIN_VERSION}-${OCPN_API_VERSION_MAJOR}.${OCPN_API_VERSION_MINOR}</string>
            <key>REFERENCE_FOLDER_PATH</key>
            <string>.</string>
rgleason commented 4 years ago

CPack: Create package

 CPack: - package: C:/Users/Rick/Documents/GitHub/squiddio_pi/build/squiddio_pi-1.0.17.1_msvc-10.0
  .18362.exe generated.
  CPack: Create package using TGZ
  CPack: Install projects
  CPack: - Install project: squiddio_pi
  CPack: Create package
  CPack: - package: C:/Users/Rick/Documents/GitHub/squiddio_pi/build/squiddio_pi-1.0.17.1_msvc-10.0
  .18362.tar.gz generated.
rgleason commented 4 years ago

Also earlier in the build found these lines:

-- Building with embedded tinyxml
-- Install Prefix: C:/Program Files (x86)/squiddio_pi
-- CPACK_PACKAGE_VERSION 1.0.17-ov50
-- FILE: opencpn-plugin-squiddio_1.0.17-ov50-ov50_win32    <---ov50 twice  Use for Github Release
-- FILE: squiddio_pi-1.0.17.1_msvc-10.0.14393   <--- use for Plugin Manager
-- CPACK_PACKAGE_VERSION: 1.0.17-ov50, PACKAGE_VERSION 1.0.17, CPACK_PACKAGE_FILE_NAME: squiddio_pi-1.0.17.1_msvc-10.0.14393
-- PKG_TARGET: msvc, PKG_TARGET_VERSION: 10.0.14393
-- Configuring done
-- Generating done

This might help sort the naming out.