mauroc / squiddio_pi

squiddio_pi
3 stars 13 forks source link

PR #83 - stable versions testing #84

Closed mauroc closed 4 years ago

mauroc commented 4 years ago

the unstable packages were all deployed correctly from circleci and appveyor for an untagged release

The stable packages did not deploy to squiddio-stable. The process I followed in this case was:

# updated version to 1.0.17.3 in Cmakelists.txt
git commit -am 'v 1.0.17.3'
git tag v1.0.17.3
git log # showed latest commit is tagged correctly as v1.0.17.3
git push origin v1.0.17.3 # this one did not trigger the circleci builds. Only appveyor
git push origin master # this one triggered all the builds, but none were deployed to squiddio-stable

what am I doing wrong? I feel we are so close....

rgleason commented 4 years ago

Maybe you put the tag in the ci/circleci-uploads.sh ? Sort of a pain.

mauroc commented 4 years ago

I didn't and would not know where in that file they would go. The issue also affects the appveyor build, not just circleci

rgleason commented 4 years ago

This should work, provided you issue it quickly enough. The problem is appveyor builds quite quickly. So maybe make the tag before pushing the commit. git tag v1.0.19.1 Then push git push origin v1.0.19.1

I've had appveyor complete before I did the git push origin v1.0.19.1 and there is no file pushed, it just stops.

Don't know about the circleci / cloudsmith

leamas commented 4 years ago

You missed git push --tags. Without the --tags option the tag is not visible in the github account.

leamas commented 4 years ago

BTW: The links provided by @rgleason are not relevant, we are not using this kind of functionality.

rgleason commented 4 years ago

Alec That is not correct they are visible without the tags option. I've been using it this way and they are clearly visible in the Tags tab under Releases.

leamas commented 4 years ago

This issue is about the cloudsmith deployment of installer artifacts, nothing else. They have never been available on github.

leamas commented 4 years ago

Could you please stick to the subject? Which is problems deploying the installer artifacts on cloudsmith. Full stop.

Yes, tags are of course visible on github. But it has nothing to do with the subject.

leamas commented 4 years ago

Going back to the problem, we have the following log building c4d5cf6

++ git rev-parse --short=7 HEAD
+ commit=c4d5cf6
++ git tag --contains HEAD
+ tag= 

The log means that there is no tag visible which points to c4d5cf6. This might be because the tag isn't pushed -- according to initial logs it isn't. It could also be because while it exists it doesn't match c4d5cf6 i. e. there was a commit after the tagged one.

leamas commented 4 years ago

@rgleason: You could also just check the tags available in the github interface (tags, not releases!). V1.0.17.3 is not there. Could we now stop this confused discussion?

mauroc commented 4 years ago

success! (didn't know about the --tags option). All 10 artifacts are uploaded to the stable repo See them in all their digital splendor. Amazing work guys

image

mauroc commented 4 years ago

I wrote the following to myself. I don't deploy new releases very often, so I am sure the next time I will have forgotten most of the process. I thought it may be useful for our online docs, as an intro to a more technical step-by-step. It would also be useful to include guidelines for the PA (plugin admin) in terms of

leamas commented 4 years ago

This repo needs to be cleaned of old artifacts periodically

There is actually a retention policy setting for the cloudsmith repo you could set to just keep the last say 30 packages or so.

rgleason commented 4 years ago

I thought that for free opensource, retention policy is automatic.

leamas commented 4 years ago

Nope. You can find the Retention Rules settings in the left pane after pushing the Set Me Up button in the cloudsmith repo.