Some icons rendered abnormally

[absop]

The theme render icons for some files abnormally, such as README, .gitignore, and git Untracked files etc.

[mauroreisvieira]

Hey, @absop thanks for the report. I will fix that ASAP.

[absop]

Thanks for replying and your great job, this theme is pretty nice.

The icons for .gitignore and README.md filse is not that mean, it is actually for + of git diff.

Here is the display of same files under other theme.

[mauroreisvieira]

Hey @absop I understand, because on Github Theme I use some letters (M, S, U) instead of a simple dot or plus...

Can you tell me what version of Sublime you use and what is your machine (Mac, Window, or Linux)?

p.s: I'm working on the Dimmed version, so I will do everything in the same release.

[absop]

Sublime Text 4102, Windows 10		zlang0

@. | 签名由网易邮箱大师定制 On 4/20/2021 17:44，Mauro Reis @.> wrote：

Hey @absop I understand, because on Github Theme I use some letters (M, S, U) instead of a simple dot on plus.

Can you tell me what version of Sublime you use and what is your machine (Mac, Window, or Linux)?

p.s: I'm working on the Dimmend version, so I will do everything in the same release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[absop]

Hi, Thank you for keeping going to work on this theme. It has been updated on my machine know, but the issue still there while I select the entry of Github theme, and there is a new issue, that is the icon of folders has been changed, but only occurs in the Github theme entry.

[absop]

And if I make use of the combination of the Github theme Theme and some another Color Scheme, the icon will be shown as below.

[absop]

And I found two issue of the Dark & Dimmed variant.

• The first one is about the tab bar, the main color of the tab bar does not match the color of the tabs.
• The second one is about the font displayed in status bar, which is a little blurry.

[mauroreisvieira]

Hi @absop GitHub Theme not exists, now we have:

• GitHub Light
• GitHub Dark
• GitHub Dimmed

ST save GitHub Theme in your local machine, but in reality, it's was deleted.

---

And I found two issue of the Dark & Dimmed variant.

• The first one is about the tab bar, the main color of the tab bar does not match the color of the tabs.
• The second one is about the font displayed in status bar, which is a little blurry.

About that I will check, thanks for the report.

[absop]

Hi @absop GitHub Theme not exists, now we have:

• GitHub Light
• GitHub Dark
• GitHub Dimmed

ST save GitHub Theme in your local machine, but in reality, it's was deleted.

And I found two issue of the Dark & Dimmed variant.

• The first one is about the tab bar, the main color of the tab bar does not match the color of the tabs.
• The second one is about the font displayed in status bar, which is a little blurry.

About that I will check, thanks for the report.

The Github Theme.sublime-theme file still included by the package. Github Theme

[mauroreisvieira]

WOW, it was an error, which must have occurred during the merge.

But it will be eliminated.

Regarding the Tabs the problem is the fact that the Theme extender of the Adaptive Theme native to ST.

I will resolve this ASAP

[mauroreisvieira]

Hey, @absop can you please tell me if, the issues were solved?

[absop]

Hey, @absop can you please tell me if, the issues were solved?

Yes, it's solved. It looks much better than before, it's a significant improvement. There is just a little problem, that is, the dark series themes input box seems a little too bright in contrast to the surrounding colors, I think we can make them a little darker.

[mauroreisvieira]

Hey, thanks for your feedback.

That is not possible to fix, because the color of the text inside the input comes from the scheme, so is not possible to customize it.

I can change the Input background, but with Light Schemes will be not possible to read what is written inside.

[absop]

Another problem is, under the Light theme, when the console line input box loses focus, it's color goes gray.

[absop]

Hey, thanks for your feedback.

That is not possible to fix, because the color of the text inside the input comes from the scheme, so is not possible to customize it.

I can change the Input background, but with Light Schemes will be not possible to read what is written inside.

That's okay. I got it.

[absop]

I actually liked the theme that automatically adapts to the Color Scheme (The privious Github Theme). I think we can keep it, by making it complete and adding some Settings for it to give users some room to personalize it (such as adjusting the height of tab bar). In addition, the Light, Dimmed, and Dark themes can inherit the adaptive GitHub Theme directly by setting the variables in the GitHub Theme to a fixed value. This makes it easier to maintain these themes.

[mauroreisvieira]

In fact, I created the Meetio Theme which is fully adaptable to the scheme color, so you can install and do a lot of overrides to default variables.

But the idea of GitHub Theme is no longer an adaptable one, but a "copy" adapted to Sublime Text from GitHub's VS Code themes.

So, for now, I don't have a plan to put GitHub Theme adaptive again.

p.s: These new themes are only available for ST4, so if you like the previous approach (adaptive) you can install manually the GitHub Theme from the st3 branch.

[Drarok]

I'm still on the release version of ST3, and the icons are messed up for me too. Can we get the fix back-ported to the ST3 releases please?

[mauroreisvieira]

Hey @Drarok, I will fix that on ST3.