Keyboard interruption doesn't stop threads that were caused by crawling

maurosoria / dirsearch

Web path scanner

11.89k stars 2.31k forks source link

Keyboard interruption doesn't stop threads that were caused by crawling #1187

Open shelld3v opened 2 years ago

shelld3v commented 2 years ago

What is the current behavior?

In /lib/core/fuzzer.py, new crawls (Fuzzer.scan session) are started in Fuzzer.scan, but play_event is only checked in Fuzzer.thread_proc; therefore, dirsearch will keep starting new crawls for pages even if the user interrupts it

What is the expected behavior?

Move play_event check to Fuzzer.scan

Checker:

[x] I tested in the latest version of dirsearch

maurosoria commented 7 months ago

What about this? We want to fix that or is aleady fixed?

shelld3v commented 7 months ago

What about this? We want to fix that or is aleady fixed?

I don't remember fixing this, probably not fixed yet

maurosoria commented 7 months ago

IMO we should start by separating the Crawl function to another module of the application. Also I like to have the possibility of differen crawl implementations. Then we should feed the Crawler with discovered endpoints, create a thread, and there manage the keyboard input output.