Open somatronicon opened 3 years ago
Sorry, just noticed that the screenshot above doesn't show the shaders being applied. However, you can still see the yellow border around the ShaderGlass main window.
Hey, thanks for the feedback. Yes the yellow border is unfortunate but it's a security feature of Windows Capture API and cannot be removed (OBS etc. also has this problem). The only way to avoid it is to use clone mode (either capture the other monitor if you have multiple, or capture just the window of your game/app and put ShaderGlass in front of it), please try setting up your content that way.
Very interesting... Totally understandable then as it's a limitation of the API used to capture. I'll give clone a shot and see what happens. Unfortunately I only have a single monitor, and am after retro-izing my entire desktop... So, I might just have to live with the yellow border for now.
BTW, I just stumbled onto this; maybe useful?:
https://www.gitmemory.com/issue/microsoft/Windows.UI.Composition-Win32-Samples/46/829032545
Also, just for some context, I traced that snippet back to the following github issue; unfortunately, I can't tell if it'd be applicable in this case judging from the API docs:
https://github.com/microsoft/Windows.UI.Composition-Win32-Samples/issues/46
So I was going through some Windows documentation, and found that this page now references a borderless capture requests.
Maybe this can help solve this issue? I'll drop it here just in case.
Great find @trebory6 , I will test this out!
No problem @rohatsu! I was actually searching how to disable it universally via the registry or something(My media center is mainly offline so not worried about rogue screen capture).
This was where I found out about the borderless capture request, and apparently that reply mentioning this document is relatively new as that response was posted only 10 days ago, so this seems like a relatively new development that I hope helps with this project!
Thanks again for this project by the way. This is EXACTLY what I've been looking for for my Retro media center project for years! Let me know if you have a patreon or paypal, I'd love to throw some coffee money your way for this.
The good news is removing yellow border works, the bad news is that at the moment only on Windows 11. Hopefully Microsoft will include this in an upcoming Windows 10 update (21H2 perhaps? I haven't tried the preview yet). On the latest released Windows 10 21H1 (build 19043.1165) it does not work unfortunately.
Feel free to give it a shot, the 0.5 beta will attempt to disable the border if the OS reports support for it. https://github.com/rohatsu/ShaderGlass/releases/tag/v0.5-beta
Edit: confirmed still not possible on latest Windows 10 21H2 preview (19044.1200), we'll have to wait longer to have this feature on Windows 10 it seems.
Hi.
Was hoping to write a full screen LUT shader for reasons, stumbled headlong into this issue "yet again", just popping a note here to say I'd love to see it solved.
Otherwise, thanks for your application; it's been a trip down memory lane testing it against old game footage. I've not felt this young in... well, my age minus about 8 years ;)
obs does not have this problem
True, I think this is the relevant portion: https://github.com/obsproject/obs-studio/pull/4070
obs does not have this problem
It does if you use the "Window 10 (1903 and up)" display capture method.
Any updates on this issue?
I am not able to reproduce yellow border on latest Windows 11 (22H2), I've added steps to confirm ShaderGlass has Windows' permission to suppress it to the FAQ but in my testing they get enabled by default. If anyone is on latest Windows 11 and those steps don't make yellow border disappear, please post here.
Still an issue on Microsoft Windows 10 Enterprise 10.0.19045 N/A Build 19045
with ShaderGlass-0.9-win-x64
Still an issue in Windows 10 pro 22H2
First off, great project! Absolutely love it. Until people figure out there is a market for poly lenses that emulate CRTs for LED monitors (akin to this: https://hackaday.com/2021/06/16/fit-your-lcds-with-lenses-for-that-vintage-crt-look/), I'm using ShaderGlass 👍
As I'm trying to immerse myself in the past, I'm a bit distracted by the yellow border that appears around the full-screen window. My configuration can be seen below:
And the screenshot: