search

mausimus / ShaderGlass

Overlay for running GPU shaders on top of Windows desktop
GNU General Public License v3.0
1.02k stars 37 forks source link

Ctrl+Shift+S is unfortunate choice for screenshot. #44

Closed ythoimust closed 1 year ago

ythoimust commented 2 years ago

ShaderGlass and its choice of ctrl+shift+s is rather unfortunate. That shortcut is used by all sort of software as "save as" but now instead I get snapshot. Since ShaderGlass is an overlay software it cannot just hijack crucial hotkeys. So some way to modify hotkeys would be nice.

skeddles commented 2 years ago

Since it seems to disable itself when you try to take a screenshot normally, perhaps they could do ctrl+printscreen or something to force taking a screenshot.

Ideally you could change the hotkeys and allow normal screenshots to include the CRT view

mausimus commented 2 years ago

Thanks, I'll add some options to enable/disable or possibly change the screenshot hotkey. I won't be able to make Windows default screenshot capture ShaderGlass window in Glass mode since that's how it achieves the transparency effect (should work in Window mode).

PiorGit commented 1 year ago

Hello Mausimus,

This might not seem like much, but indeed this screenshot hotkey really gets in the way. My practical case is as follows :

I am using Shaderglass to duplicate (and flip, and downres/blur) my current working document in Photoshop. The Shaderglass Ctrl Shift S screenshot hotkey is conflicting with my Photoshop Save As hotkey. As a matter of fact I am writing this as I just got the case right now : I was meaning to save out a document which just happened require PNG as a format, and without realizing it I saved a ShaderGlass screenshot instead. I am glad I caught it before closing Photoshop, otherwise I would have lost some work.

I understand that this is an edge case but it literally caused me to not save something I was meaning to save. As far as I am concerned I'd be happy with a custom build with the screenshot feature disabled, or even all hotkeys removed altogether as the risk of triggering a Shaderglass hotkey while working is just too high.

I hope this makes sense. Thank you for an amazing piece of software - I had been looking for something like this for years and finally came across it recently on a friends recommendation. It is extremely useful for digital art.

PiorGit commented 1 year ago

By the way - I should also probably mention that the very issue with this hotkey is that unlike other ones like Next Shader and Random Sgader, it gets triggered even when ShaderGlass isn't in focus. The same special behavior seems to apply to the Fullscreen hotkey too.

Now I can understand this design/reasoning when ShaderGlass is being used for gaming, but I feel like a better design would consist of letting the user define their shortcuts, and letting them decide if a given shortcut is supposed to be global (= working even when the SG window isn't in focus) or not, on a per-hotkey basis.

mausimus commented 1 year ago

Added option to disable global hotkeys in 0.8