search

mautic / api-library

Mautic API Library
MIT License
178 stars 122 forks source link

Remove CitrixPlugin from tests #304

Closed mabumusa1 closed 1 year ago

mollux commented 1 year ago

@mabumusa1 we can't do this like this. We need a separate major release, as this behavior is different between 4 and 5

mabumusa1 commented 1 year ago

@mabumusa1 we can't do this like this. We need a separate major release, as this behavior is different between 4 and 5

@mollux Good point, how do you suggest we do it, since we do not have separate branches

codecov-commenter commented 1 year ago

Codecov Report

Merging #304 (d94231f) into main (28190cb) will not change coverage. The diff coverage is n/a.

:exclamation: Current head d94231f differs from pull request most recent head 08556a8. Consider uploading reports for the commit 08556a8 to get more accurate results

@@            Coverage Diff            @@
##               main     #304   +/-   ##
=========================================
  Coverage     51.96%   51.96%           
  Complexity      407      407           
=========================================
  Files            30       30           
  Lines          1093     1093           
=========================================
  Hits            568      568           
  Misses          525      525

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

escopecz commented 1 year ago

I think we can merge this and release it together with M5 as a new major release. There are other PRs with BC changes that we should get in.