search

mautic / developer-documentation-new

New developer documentation on Read the Docs
https://mautic-developer.readthedocs.io
6 stars 29 forks source link

Write documentation for Event Listeners component #215

Open favour-chibueze opened 2 months ago

favour-chibueze commented 2 months ago

We need to write documentation on the Event Listeners component.

https://devdocs.mautic.org/en/5.x/plugins/event_listeners.html

ifeoluwafavour commented 1 month ago

Hello @favour-chibueze Please I would like to work on this issue Are these the event listeners to be documented? https://github.com/mautic/mautic/tree/5.x/app%2Fbundles%2FPluginBundle%2FEventListener

favour-chibueze commented 1 month ago

Sure.. see the old documentation too for the event listeners.

ifeoluwafavour commented 1 month ago

Okay. Thank you!

ifeoluwafavour commented 1 month ago

hello @favour-chibueze @RCheesley I have created a pull request with the documentation for the Even Listeners component and it is ready for reviews because I'm not so sure about it 😅

RCheesley commented 1 month ago

Fabulous @ifeoluwafavour thanks for doing that! I've done a review and made some suggested fixes for the grammar. Let's get that fixed first, then we can ask a core team member to do the technical review for accuracy.

ifeoluwafavour commented 1 month ago

Hello @RCheesley Thank you for your kind words. I'm learning a lot!

I have applied the suggested changes. To accurately follow the external link syntax, I created a pull request to include Symfony's docs event subscribers link file to the link folder: https://github.com/mautic/developer-documentation-new/pull/221/checks

P.S. I made this same comment yesterday thinking it was under this issue but it was under my pull request 😅