mautic / docker-mautic

Docker Image for Mautic
https://www.mautic.org
362 stars 274 forks source link

Docker compose for v3 typo #188

Open exsesx opened 3 years ago

exsesx commented 3 years ago

PLEASE correct the typo below. Took me about a few hours to get it up and running 🤦🏼‍♂️ 🤕

https://github.com/mautic/docker-mautic/blame/mautic3/README.md#L182 (should be 8080, not 8880 :c)

--- Want to back this issue? **[Post a bounty on it!](https://app.bountysource.com/issues/96841831-docker-compose-for-v3-typo?utm_campaign=plugin&utm_content=tracker%2F20392502&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://app.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F20392502&utm_medium=issues&utm_source=github).
exsesx commented 3 years ago

docker-compose up doesn't work v3 (for people who have encountered or will encounter the same problem)

RCheesley commented 3 years ago

@exsesx how about making a PR to fix this? Would you like any help to get started?

exsesx commented 3 years ago

@RCheesley yeah, I would be glad to create a PR. Cannot push a new branch tho...

RCheesley commented 3 years ago

@exsesx please fork the repo and make the PR from your fork. There are more details here on how to make PRs: https://contribute.mautic.org/contributing-to-mautic/developer/code/pull-requests

exsesx commented 3 years ago

@RCheesley Okay, thanks!

exsesx commented 3 years ago

Are we ready to merge this?