search

mautic / docker-mautic

Docker Image for Mautic
https://www.mautic.org
374 stars 278 forks source link

Common files cleanup and environment variable configuration rework #195

Closed thinkl33t closed 3 years ago

thinkl33t commented 3 years ago

An effort has been made in the past to combine any dockerfiles into a central location, but wasn't finalized (i assume due to docker not allowing includes from directories higher up).

This completes this work, and documents how to run the Dockerfiles to produce working containers.

Additionally, this MR changes the environment variable config so that any environment variable changes are re-applied to local.php on container startup. It is part of some work I am doing to help make the mautic containers more devops friendly.

cla-bot[bot] commented 3 years ago

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @thinkl33t.

thinkl33t commented 3 years ago

CLA should be signed - @cla-bot check

cla-bot[bot] commented 3 years ago

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @thinkl33t.

cla-bot[bot] commented 3 years ago

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

RCheesley commented 3 years ago

@cla-bot check

Sorry this is a manual process @thinkl33t so it takes a bit of time before one of us adds signatories to the list :)

Done now!

cla-bot[bot] commented 3 years ago

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

RCheesley commented 3 years ago

Thank you for making the PR @thinkl33t - have requested a review from the core team and @luizeof who maintains the Docker image at present!

thinkl33t commented 3 years ago

Closing this as it is obsolete as of #196