mautic / documentation

Mautic End User Documentation
Apache License 2.0
62 stars 141 forks source link

Zapier OAuth2 Docs update #375

Closed kuzmany closed 4 years ago

kuzmany commented 4 years ago

https://github.com/mautic/mautic-zapier/pull/18

kuzmany commented 4 years ago

@RCheesley I see. Thanks

kuzmany commented 4 years ago

@escopecz How we handle with basic auth info. Should remove it, or just notice about changes from basic auth to oauth. Or let setup also for 2.x (basic auth) and 3.x (oauth2) separately

escopecz commented 4 years ago

I guess we can remove it. The question is whether we want to wait with the Zapier Oauth2 PR till we fix the refresh token expiration or add to the docs to increase the refresh token lifetime to some big number.

kuzmany commented 4 years ago

@escopecz that refresh token expiration should be updated on every access token generate. That means, app stop working just If there is no usage during that expiration (default 14 days). Should we add just note to docs?

escopecz commented 4 years ago

@kuzmany you don't sound confident :) You said a customer of yours already runs this version. There are no problems with timeouts? Is their expiration value default at the Mautic API configuration?

A note in the docs would be great.

kuzmany commented 4 years ago

@escopecz It was bug, we didn't store updated refresh_token. But at the moment looks good. I did few tests