search

mautic / mautic-wordpress

Wordpress Plugin
124 stars 53 forks source link

Create Wordpress Gutenberg Blocks for All Shortcodes #119

Open weismannweb opened 3 years ago

weismannweb commented 3 years ago

Any interest in this?

--- Want to back this issue? **[Post a bounty on it!](https://app.bountysource.com/issues/108499061-create-wordpress-gutenberg-blocks-for-all-shortcodes?utm_campaign=plugin&utm_content=tracker%2F9142157&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://app.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F9142157&utm_medium=issues&utm_source=github).
weismannweb commented 3 years ago

https://calderaforms.com/2019/01/convert-shortcode-gutenberg-block/

shulard commented 3 years ago

Hello !

Aren't the shortcodes still supported ? Introducing Gutenberg blocks will imply adding some JS things and this plugin will be more complex to maintain… I'm not sure it's relevant to make that conversion now. Maybe you can ask on Mautic support forum if it's an interesting thing to be done for our current users.

weismannweb commented 3 years ago

yes they are still supported but blocks is the path forward and i imagine at some point it will be needed, also shortcodes are sometimes not supported in other shortcodes or some blocks i think unless you use a hook and do_shortcode on that content via a filter, blocks are much more user friendly too, but your right this would be harder to maintain, maybe you can make me the appropriate hooks (unless wp hooks can do it), or do the right refactoring so i can call the right functions, so that i can turn your code into blocks with a seperate companion plugin? i am also interested in doing the counter from #114 which i can commit a shortcode for here, and have a block in my plugin