search

mautic / website

The Mautic Website
6 stars 4 forks source link

Add seo fields #66

Closed RCheesley closed 5 years ago

RCheesley commented 5 years ago

Pretty minor changes - just adding a component to layouts.

Note that if we want to differentiate between types of pages we'd need to have separate layouts.

kuzmany commented 5 years ago

Looks briliant. We can go to staging with it and marge PR. Do you have permission for that?

RCheesley commented 5 years ago

Fab, have merged. I've pushed up to staging.

kuzmany commented 5 years ago

Just noticed, this plugin destroy our custom page title Now http://staging.mautic.org/mauticamps/atlanta/forum http://staging.mautic.org/mauticamps/mautic-meetup-curitiba

I found solution https://octobercms.com/plugin/support/anandpatel-seoextension/how-to-override-seo-extensions-page-title-seocmspage

But I don't know If it's good idea change all setup titles. Maybe exists more elegant solution, but don't know now

RCheesley commented 5 years ago

Ok I'll take a look!

On Mon, 11 Mar 2019, 23:49 Zdeno Kuzmany, notifications@github.com wrote:

Just noticed, this plugin destroy our custom page title Now http://staging.mautic.org/mauticamps/atlanta/forum http://staging.mautic.org/mauticamps/mautic-meetup-curitiba

I found solution https://octobercms.com/plugin/support/anandpatel-seoextension/how-to-override-seo-extensions-page-title-seocmspage

But I don't know If it's good idea change all setup titles. Maybe exists more elegant solution, but don't know now

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mautic/website/pull/66#issuecomment-471786711, or mute the thread https://github.com/notifications/unsubscribe-auth/ACy3oUUqDARmmoZVb5CC-b7htK2UIGo2ks5vVuuWgaJpZM4bori1 .

RCheesley commented 5 years ago

I've flagged this on the GH repo for the current plugin (a fork of the old SEO Extension which was not being maintained) asking how to proceed https://github.com/suresoftware/october-power-seo/issues/3

RCheesley commented 5 years ago

@kuzmany did you give this a try for the forum where the title was lost:

function onStart() { $this->layout->components['SeoCmsPage']->seo_title = $dynamicTitle; }

kuzmany commented 5 years ago

I don't like it. We have to change it on many places. But we have no choice

RCheesley commented 5 years ago

I think we just need to change it on the group layout, where else does the dynamic title not work?

On Tue, 19 Mar 2019, 00:02 Zdeno Kuzmany, notifications@github.com wrote:

I don't like it. We have to change it on many places. But we have no choice

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/mautic/website/pull/66#issuecomment-474147213, or mute the thread https://github.com/notifications/unsubscribe-auth/ACy3oYzAPZDKuCyaowLRhXEFd7aN-9E1ks5vYCkTgaJpZM4bori1 .