mautic / website

The Mautic Website
6 stars 4 forks source link

Content sticks to the footer rather than header #88

Closed escopecz closed 5 years ago

escopecz commented 5 years ago

It's probably on every page but best visible on the download page with higher resolution monitor:

http://staging.mautic.org/download

Screenshot 2019-04-23 at 12 42 33

There is big gap between the div with logo and div with top menu.

escopecz commented 5 years ago

It seems to be related to

*, *::before, *::after {
    box-sizing: border-box;
}

As if I turn it off the gap is gone. But then the columns in the content too.

escopecz commented 5 years ago

Better solution is probably to turn off these and the page looks good:

.page {
    /* display: -ms-flexbox; */
    /* display: flex; */
    /* -ms-flex-direction: column; */
    /* flex-direction: column; */
    /* -ms-flex-pack: center; */
    /* justify-content: center; */
    min-height: 100%;
}
RCheesley commented 5 years ago

Applied this fix to staging which seems to resolve the issue. Not sure what that code was for but it might need revisiting just in case it breaks the world - do we have access to cross-browser testing?

escopecz commented 5 years ago

Thanks Ruth! I'm not sure we have.