mautrix / imessage

A Matrix-iMessage puppeting bridge
https://go.mau.fi/mautrix-imessage/
GNU Affero General Public License v3.0
348 stars 37 forks source link

[bluebubbles] Implement GetChatInfo #143

Closed cnuss closed 8 months ago

cnuss commented 8 months ago

https://github.com/mautrix/imessage/commit/c314edf39987a4f30064e16dc30ded206db02ca0#diff-add0e027970853876947ede515fd2419541057010ed0cfb334f30219fcd9979fR103

trek-boldly-go commented 8 months ago

@cnuss I see you have added some code for both of these functions. Is it safe to close this issue? There is always room for improvement later, but if it works then it works (in my book at least).

cnuss commented 8 months ago

I added a private function but the public function that transposes the BB API into the internal imessage Struct still needs to be written (getChatInfo [done] vs GetChatInfo [not done])

trek-boldly-go commented 8 months ago

Actually I think you already connected the two from what I can tell:

image
cnuss commented 8 months ago

my memory failed me! I think I was thinking of GetChatMessage

closing!