using any over interface{}

mautrix / imessage

A Matrix-iMessage puppeting bridge

https://go.mau.fi/mautrix-imessage/

GNU Affero General Public License v3.0

332 stars 36 forks source link

using any over interface{} #189

Closed dltacube closed 4 months ago

dltacube commented 4 months ago

Changelist

[x] convert interface{} to any ref
[x] convert time.Millisecond to time.UnixMilli() ref
[x] something something initialisms ref
[x] refactor for reconnect ref initial implementation: https://github.com/mautrix/imessage/pull/188

Gonna move these to another PR

some config options should be based on whether or not private apis are enabled ref
debug log clean up ref
🔪 😵‍💫 ❤️ ref

dltacube commented 4 months ago

I just realized there are exceptions when it comes to initialism in cases where the variable or function's scope needlessly changes from the original authors intent.

Will fix that.

dltacube commented 4 months ago

I reverted this commit but do we want to make changes like this here that change the scope of the function? https://github.com/mautrix/imessage/pull/189/commits/2c1a437bf33179bf55945f8649e03f9e73382987

trek-boldly-go commented 4 months ago

Closes #184 @cnuss I can't merge because the last commit is from me. Can you approve and merge this?

trek-boldly-go commented 4 months ago

@tulir I think GH is going to require an approval from you on this one. I think it is the edit to the tapbacks file that triggered it.