search

mautrix / imessage

A Matrix-iMessage puppeting bridge
https://go.mau.fi/mautrix-imessage/
GNU Affero General Public License v3.0
341 stars 37 forks source link

Add the "@" before any mention #59

Closed shreyasajj closed 2 years ago

shreyasajj commented 2 years ago

Basically I added the ablity to create a @ before the displayname. The displayname was already getting bridged so I really just made a complicated way to add "@". I know it a lot for only that but by the time I figured that all I did I was done. So it here, technically it should be the correct way of handling mentions but ehh. It here if you want. Really dont think there is much issue it was copied from whatsapp.

tulir commented 2 years ago

Does it actually turn into a mention on iMessage just by adding a @ in the plaintext? :thinking: (if not, I don't really see the point of this)

shreyasajj commented 2 years ago

It does not turn it into a mention, however though my testing I found that whenever relay mode is active and the bot mention someone, It will show the mxid. Example, maubot: shredmaster:example.com: hi instead of maubot: @Me (iMessage): hi. It does add a bit of functionality for clarity sake

shreyasajj commented 2 years ago

Why, I kind of forgot

shreyasajj commented 2 years ago

I think you fixed it