search

mautrix / signal

A Matrix-Signal puppeting bridge
GNU Affero General Public License v3.0
499 stars 75 forks source link

Don't replace bridged reactions sent from Matrix #431

Closed AndrewFerr closed 8 months ago

AndrewFerr commented 8 months ago

This is the second commit of https://github.com/mautrix/signalgo/pull/20 that I had mentioned wanting to open a PR for.

sumnerevans commented 8 months ago

In https://github.com/mautrix/signalgo/pull/20#issuecomment-1825854788:

Ah, the error I'm getting is M_DUPLICATE_ANNOTATION (HTTP 400): Can't send same reaction twice, when a bridged Matrix user sends a reaction in a portal. This happens because the attempt to delete the original reaction fails with M_FORBIDDEN (HTTP 403): You don't have permission to redact events.

This seems like the actual issue, we should just make the redaction work properly instead of patching it with this hack.