search

mautrix / whatsapp

A Matrix-WhatsApp puppeting bridge
https://maunium.net/go/mautrix-whatsapp
GNU Affero General Public License v3.0
1.21k stars 170 forks source link

Bridge turns on encryption in existing Matrix room #293

Open vranki opened 3 years ago

vranki commented 3 years ago

(Scenario is existing Matrix room to new WA room)

Steps to reproduce:

  1. Invite bot to room
  2. Give bot admin permissions (yes, this is wrong. It works with PL0)
  3. Bridge
  4. Bot turns on encryption in room, which cannot be reversed

Encryption can't be turned off, so in practice the Matrix room is now unusable and must be recreated.

tulir commented 3 years ago

Is bridge->encryption->default set to true?

zouppen commented 3 years ago

This is very bad in multi-bridged rooms where some of the bridges do not yet support end-to-end encryption such as matrix-appservice-irc

zouppen commented 3 years ago

Is bridge->encryption->default set to true?

It is not set at all, so the default value, whatever it is.

zouppen commented 3 years ago

We bridged the channel using !wa relaybot create and it turned the encryption on. The configuration doesn't have encryption setting. (We followed this https://docs.mau.fi/bridges/go/whatsapp/relaybot.html#creating-a-new-whatsapp-group-for-an-existing-matrix-room )