FF 33.0 seems to have broken beta 103

[GoogleCodeExporter]

Before submitting the issue, please check that your version of TabGroups
Manager is the lastest stable one. (Check it in Firefox Extensions).

What steps will reproduce the problem?
1. Using the most recent beta 2013.08.21.003
2. Dpdating to FF 33.0 just released
3.

What is the expected output? What do you see instead?
Expect to be able to add new tab groups, restore hibernated groups.  Instead, 
attempts to open a new group create a new tab group but without any tabs at all 
(0), and a new bank tab in whatever current tab group was already open, and 
trying to restore a hibernated group opens that tab group, but with 0 actual 
tabs(though sometimes does eliminate that group, permanently, from the 
hibernated list)

System Info:
What version of TabGroups Manager are you using?
- beta 2013.08.21.003
What Operative System are you using? 32 or 64 bits?
- Windows 7 64 bit
What version of Firefox are you using?
- FF 33.90
Are you using any other tab extension like Colorfull tabs, Multiple Tab
Handler, TabMix Plus..?
- yes, TabMixPlus, Tab Renamizer

Please provide any additional information below and screens capture if
possible.

I've been still using the original TGM all along, which for some reason for me, 
with some massaging, like making sure I do manual saves before quit-saving, and 
sometimes 2-3 tab groups reload attempts after a FF update seemed to make it 
not work, has been working for me all along up through FF 32.0.3. 

Update to FF 33.0 seems to have finally destroyed functionality as above, so I 
tried updating TGM instead (have been hesitating to due to the many reported 
problems with the new version, and the original TGM still working for me, I 
count on it too much).  But, the new version has the same problem as the 
original, as above 

Original issue reported on code.google.com by mtpric...@gmail.com on 14 Oct 2014 at 10:05

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Thank you very much for the detailed report. Hope to be able to check it on 
this weekend. Meanwhile I would suggest temporarily downgrading to FF 32+.

Fortunately for us some new members joined the team and they will be also able 
to help us :)

Original comment by miguelro...@gmail.com on 14 Oct 2014 at 10:28

[GoogleCodeExporter]

That I did (had to) already, but, as they say themselves, reverting to
out of date versions is a less than desirable solution for many reasons.  

I'm a past software developer myself, though not of FF extensions, so
dunno much about that, but value this extension enough - I�m very
dependent on it for keeping things organized - that I'd thought to look
into trying to upgrading it even before this group started (which I've
kind of followed out of the corner of my eye, knowing the original TGM
would break eventually, even if for me it had kept going this long)
though never did in part because the original TGM kept working for me,
and also people started saying upgrading it would be very very
complicated due to the depth of the changes in FF - but, so I may join
you to help out eventually, tho can't now or for the near future....

Original comment by mtpric...@gmail.com on 14 Oct 2014 at 10:36

[GoogleCodeExporter]

I have observed the same thing.

Original comment by i...@flexxifinger.com on 14 Oct 2014 at 10:38

[GoogleCodeExporter]

Same issue. No functionality in FF33.

Original comment by j...@brandloyal.com on 15 Oct 2014 at 1:18

[GoogleCodeExporter]

Same issue here.

Original comment by seraphtc...@gmail.com on 15 Oct 2014 at 12:58

[GoogleCodeExporter]

I just reported the same issue.  FF 33.0 has made TabGroupsManager unusable for 
me.

Original comment by azbryanw...@gmail.com on 15 Oct 2014 at 4:20

[GoogleCodeExporter]

same here - TGM when on, you add a tab - the tab shows in all groups, when you 
click a group - it makes blank tabs in all groups.   I also had to disable 
TabUtilites - that is broken - the address bar when you type, does not allow 
enter key to go to site.   Crazy when firefox updates bust everthing up.

Original comment by rjameson...@gmail.com on 15 Oct 2014 at 4:29

[GoogleCodeExporter]

From my experience, this bug usually happens when there is something in the 
code which is throwing a fatal error or exception and stopping TGM from 
executing more code.

Firefox 33 has deprecated and changed some functions and added some new 
fuctionality to tabs, maybe some of those changes has broken everything.
I think I will be able to begin looking at it on Wednesday or Saturday.

Original comment by miguelro...@gmail.com on 15 Oct 2014 at 9:41

[GoogleCodeExporter]

Look forward to a fix...TGM is invaluable to me...in IT - I have usually 200+ 
tabs grouped in approx 15 TGM groups.  Lots of research for client work.    
Keeps me with Firefox...chrome has no such tab organization this clean.

Original comment by rjameson...@gmail.com on 16 Oct 2014 at 1:56

[GoogleCodeExporter]

Miguel, you are correct. TGM broke this way before, back when Mozilla jumped 
into version 20's.

Quick question, do you use Mozilla's Addon debuggeror some other tool? I was 
trying to take a look with Mozilla's built-in but the debug option does not 
show up for me after enabling the tool.

Original comment by magius....@gmail.com on 16 Oct 2014 at 4:23

[GoogleCodeExporter]

Hi Magius, I use Venkman Js debugger. After many tests with other tools its the 
best one to debug Firefox extensions since it allows you to save breakpoints 
and has other features which makes it better than the default Firefox debugging 
tools. Its a bit hard to setup it at the beginning but once you understand how 
it works, u wont want any other tool. There is an article in our tgm wiki which 
could help to setup Venkman and begin to debug with it.

Original comment by miguelro...@gmail.com on 16 Oct 2014 at 6:20

[GoogleCodeExporter]

Thank you Miguel!

Original comment by magius....@gmail.com on 16 Oct 2014 at 8:43

[GoogleCodeExporter]

@Magius. Besides the long time powerful venkman, here is another one at 
https://addons.mozilla.org/en-US/firefox/addon/tiny-javascript-debugger/
Once you are at the page, there's also a review showing how to configure the 
built-in FF debug option. 

I'm not an FF add-on developer, hope this could be helpful for the fix

Original comment by tutor...@gmail.com on 17 Oct 2014 at 3:01

[GoogleCodeExporter]

Fixed, uploading new version 004 in some minutes, this time it was easy hehe ;)

Seems they finally changed some functions, fixing all of them:
https://bugzilla.mozilla.org/show_bug.cgi?id=996053
https://blog.mozilla.org/addons/2014/10/01/compatibility-for-firefox-33

Make nsISessionStore’s  functions throw for non-strings, for consistency with 
SessionStore.jsm. This affects the following functions: setTabValue, 
setWindowValue and setGlobalValue. Their third argument should be a string, and 
passing anything else will most likely throw.

Original comment by miguelro...@gmail.com on 18 Oct 2014 at 6:48

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Hi peterm, version 104 (004) is available to download and install it from:
https://code.google.com/p/tabgroupsmanager

If you want to check the changes in this version, check the lastest commit:
https://code.google.com/p/tabgroupsmanager/source/detail?r=240

I will leave the issue open until we make sure it solved and we dont see more 
crashes with FF33.

Original comment by miguelro...@gmail.com on 18 Oct 2014 at 9:57

[GoogleCodeExporter]

Fantastic - installed and seems to work perfectly

Original comment by pe...@pewe.co.uk on 18 Oct 2014 at 10:06

[GoogleCodeExporter]

Nice to know, please report if you see any issue ty :)

Original comment by miguelro...@gmail.com on 18 Oct 2014 at 10:12

[GoogleCodeExporter]

I have one issue - but it was there before the recent problems and is still 
there.

If I bookmark a tab group, then later want to open it, when I go to bookmarks 
and select 'open all in tabs', Firefox does not create a new tab group, instead 
it opens the bookmarked tabs randomly overwriting any existing tabs in existing 
open groups.

The only way I can open the bookmarked tab group is to create a new FF 
window,open the tabbed group in the new empty window and then drag/drop the 
group tab to the first FF window thereby adding the group to the existing ones.

Does that make sense?
Does anyone else have this issue??

Original comment by pe...@pewe.co.uk on 18 Oct 2014 at 10:40

[GoogleCodeExporter]

Beta 104 worked for me, so far as any issues I knew I was having (I�m
the person who posted initially that FF 33 had broken Beta 103).  I
installed 104, then upgraded FF to 33.0, and all seems OK - adding new
groups, and restoring hibernated groups, all worked as they used to.

I want to thank you, very much, for:
1) responding to this issue so quickly
2) updating the add-on (and so quickly), and
3) by doing (2), enabling me to update to FF 33 as well; I don't really
like being behind on those.

I very much hope TGM gets past beta soon, and added back to the
"official" FF Add-ons.   If y'all're still in beta by the time I can
make some time to help, I'll come try to pitch in.  This particular
add-on is among one of the very much more useful ones ever created, in
my opinion.

Original comment by mtpric...@gmail.com on 18 Oct 2014 at 10:52

[GoogleCodeExporter]

I just downloaded and tried to install Beta v104, but discovered that it is 
actually Beta v103. In Firefox Add-ons it still shows as "TabGroups Manager 
2014.08.21.004". The install.rdf file shows as being: 
<em:version>2014.08.21.004</em:version>.

I think the Beta V104 link is pulling from the same source as Beta v103.

Original comment by Impetuou...@gmail.com on 18 Oct 2014 at 11:50

[GoogleCodeExporter]

.004 is v. 104.  Beta 103 is .003

Original comment by mtpric...@gmail.com on 19 Oct 2014 at 12:26

[GoogleCodeExporter]

Hi ImpetuousNinja, the lastest version of TGM beta is v104 alias .004, which 
has the lastest source code with the fixes.

http://j.mp/beta_004_lastest is pointing to:
http://tabgroupsmanager.googlecode.com/svn/__static/product/100/beta/addon-2014.
09.18.004-fx.xpi

which is right.

Original comment by miguelro...@gmail.com on 19 Oct 2014 at 12:04

[GoogleCodeExporter]

I installed the beta & it seems to work as far as opening & closing tab groups. 
 One thing I noticed that when I hibernate the tab groups they do hibernate & 
the list of hibernated groups increases, but the count stays at 1.  When I 
close groups from the hibernated group the count doesn't decrease either.  
Other than that it seems to be working much better.

Original comment by azbryanw...@gmail.com on 19 Oct 2014 at 1:28

[GoogleCodeExporter]

But I did notice that when I close all my tab groups & restart the browser, the 
count is properly initialized to the number of hibernated groups, but then 
opening & closing groups doesn't change this number.

Original comment by azbryanw...@gmail.com on 19 Oct 2014 at 1:30

[GoogleCodeExporter]

The last two betas don't seem to handle multi-rows of tabs correctly for me.  i 
had three rows of tabs before upgrading.  now i have one row, and i can't get 
to any of the tabs past the visible row.  i do have tab mix plus installed.

Original comment by jahlborn@gmail.com on 19 Oct 2014 at 6:30

[GoogleCodeExporter]

Thanks for the speedy fix for FF33.  Much appreciated.

Original comment by seraphtc...@gmail.com on 20 Oct 2014 at 3:07

[GoogleCodeExporter]

Great job, 104 fixed it for me as well.   Wish you guys can take over Tab 
Utilities.  :)   They need faster fixing.

Original comment by rjameson...@gmail.com on 21 Oct 2014 at 5:35

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

micha guessed the issue and warned me some months ago but since the old version 
was working I didnt change anything and totally forgot about it :P

Just to add that TGM group is alive and however we dont have much time and 
updates are slower than it should be, each one of us is helping in a way or 
another with fixes, resources, documents, wiki, support.. which is an enourmous 
work and help for the community which wont be possible without all the people 
involved in TGM. 
You can join our group without worrying about not having time to code or to 
make anything, any help is really welcome :)

The issues with Tab Mix Plus are old and if we are lucky we would be able to 
look at it next weekend, but I cannot promise an exact date.

Original comment by miguelro...@gmail.com on 21 Oct 2014 at 8:57

[GoogleCodeExporter]

My sincere thanks.  This tool allows me to function efficiently. Thank you very 
much for your efforts.

Original comment by i...@flexxifinger.com on 22 Oct 2014 at 3:47

[GoogleCodeExporter]

great job! thank you thank you thank you :)

Original comment by ForM...@gmail.com on 18 Nov 2014 at 8:02

[GoogleCodeExporter]

multirow support with TabMixPlus has ben fixed in 005, please update to this 
version if you still have some problems, thank you.

Original comment by miguelro...@gmail.com on 22 Dec 2014 at 1:15

[GoogleCodeExporter]

Original comment by miguelro...@gmail.com on 22 Dec 2014 at 1:15

• Changed state: Fixed