Need Spirit Parser and Selector Code Review Changes

[GoogleCodeExporter]

Description
Moderate the following files:
Check off that the files were moderated, and not the moderated version at 

prims.h
common_actors.h
gcno_actors.h
gcda_actors.h
gcno_grammar.h
gcda_grammar.h
selector.h
selector.cpp

Original issue reported on code.google.com by millerlyte87@gmail.com on 5 Sep 2009 at 7:23

[GoogleCodeExporter]

prims.h:
line 188: Need three slashes
line 198: Return type? This seems really vague, doesn't say what it is or what 
it's for
Same with lines 229, 327, 455. You can decide if this is good enough, but I 
have no
idea what it's returning from just that one line.

selector.cpp:
Did you even touch this file? Doesn't look like you made any of the requested 
changes.

gcda_actors.h:
line 71: is_dump_ref is no longer a const bool &, so should it still be named
is_dump_ref?
line 124: Remove the @struct

Original comment by william....@gmail.com on 12 Sep 2009 at 10:26

• Changed title: Need Spirit Parser and Selector Code Review Changes
• Changed state: Accepted

[GoogleCodeExporter]

Verify changes were made. Prims.h will have to be reviewed again ( a diff 
review )
because of more significant changes.

Original comment by millerlyte87@gmail.com on 22 Sep 2009 at 3:49

• Changed state: NeedsModeration

[GoogleCodeExporter]

Original comment by william....@gmail.com on 22 Sep 2009 at 4:02

• Changed state: Moderated