mavdi / grunt-cucumberjs

Grunt plugin for cucumber.js
MIT License
31 stars 36 forks source link

added require option and also ability to imbed screenshots in reports #25

Closed nikulkarni closed 9 years ago

nikulkarni commented 9 years ago

Two features added with this PR:

Check out the screenshots embedded in HTML below. FYI, JS to collapse/expand screenshots doesn't seem to work on the views below. However this has been thoroughly tested locally and everything works well.

http://htmlpreview.github.io/?https://github.com/nikulkarni/grunt-cucumberjs/blob/screenshot/report/cucumber_report_bootstrap.html

http://htmlpreview.github.io/?https://github.com/nikulkarni/grunt-cucumberjs/blob/screenshot/report/cucumber_report_simple.html

http://htmlpreview.github.io/?https://github.com/nikulkarni/grunt-cucumberjs/blob/screenshot/report/cucumber_report_foundation.html

nikulkarni commented 9 years ago

@mavdi Can you please take a look at this? Thanks!

mavdi commented 9 years ago

@nikulkarni looks good but can you please add some documentation as to how this can be done in the README?

nikulkarni commented 9 years ago

@mavdi I updated README with instructions

mavdi commented 9 years ago

@nikulkarni Thanks, merged and published.

nikulkarni commented 9 years ago

:+1: thanks