search

mavdi / grunt-cucumberjs

Grunt plugin for cucumber.js
MIT License
31 stars 36 forks source link

fix options.tags #41

Closed gkushang closed 9 years ago

gkushang commented 9 years ago

When cucumber.js resolves the CLI args, it overwrites the user's tags. This fix will make sure user's tags are also included in the tags array and appends whatever has been passed as --tags CLI arg.

for e.g. user's cucumber.js task defines not to run tags ~@todo, ~@wip , this fix will make sure that these tags are included when user runs grunt cucumbejs --tags=@happyScenarios - this command will include tags ['@happyScenarios','~@todo','~@wip']

gkushang commented 9 years ago

Thanks @mavdi! Can you publish 0.8.1?

mavdi commented 8 years ago

Publish. what's your npm username to add you so you can publish in the future?

gkushang commented 8 years ago

thanks @mavdi. Sure, my username is kushang https://www.npmjs.com/~kushang

mavdi commented 8 years ago

Thanks, added you.

On Wed, Nov 18, 2015 at 7:09 PM, Kushang Gajjar notifications@github.com wrote:

thanks @mavdi https://github.com/mavdi. Sure, my username is kushang https://www.npmjs.com/~kushang

— Reply to this email directly or view it on GitHub https://github.com/mavdi/grunt-cucumberjs/pull/41#issuecomment-157825475 .