Open GregDomjan opened 10 years ago
[WARNING] [WARNING] * Your build is requesting parallel execution, but project [WARNING] * contains the following plugin(s) that are not marked as [WARNING] * @threadSafe to support parallel building. [WARNING] * While this /may/ work fine, please look for plugin updates [WARNING] * and/or request plugins be made thread-safe. [WARNING] * If reporting an issue, report it against the plugin in [WARNING] * question, not against maven-core [WARNING] *
@GregDomjan I am unfamiliar with that flag... or with weave for that matter...
@dscho Parallel build (-T option) was added in maven 3, part of that was a new form of parallel build called weave (W arg) which would attempt to start building modules sooner when modules reach end of compilation phase and end of test phase
This depends on changes similar to issue #71 so that dependent projects will be able to find the content to compile against. There are also other issues to be resolved such as thread safety, overlapped nar unpack to common folder and ?
https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3
Mojo thread safety assertion checklist Sometimes it can be hard to determine if a plugin and the underlying libraries are thread-safe, so when adding @threadSafe the following checklist can be used:
Known dependencies appear to be ok http://jira.codehaus.org/browse/MSHARED-148 Due to PLXCOMP-149, PLXUTILS-130 and PLXUTILS-131, the following libraries must be updated to at least the specified versions: plexus-utils version 2.0.5 or higher (already selected) plexus-io version 1.0 or higher (only used by plexus archiver) plexus-archiever version 1.0 or higher (already selected)
maven-archiver 2.4.1 or higher - unused as far as I can see Using dependency:tree -Dverbose -Dincludes=org.apache.maven:maven-archiver
Code issues CPPTasks Has a variety of static class variables, needs more detail check if they are all final or might actually change.
NarProperties has singleton instance, not good for multi thread
private static NarProperties instance;
StreamGobbler needs check
private static final class StreamGobbler
Is it just me, or are we already using weave
correctly? I was recently surprised to see that one of my own projects was built using a nice progress counter. OTOH I could not tell whether it was building in parallel because it was too fast.
I guess I mistook the Ant way to do parallel builds for weave builds.
But I fear that I really want to close this ticket. It seems not to go anywhere.
Still an issue for us though I've had no time to work on anything maven for a while. I believe issue #122 also relates to a part of this.
I believe issue #122 also relates to a part of this.
@GregDomjan quite possible.
Still an issue for us though
I am assigning this ticket to you, then.
Similar to issues with #71 the experimental maven parallel weave build requires knowledge of compile time artifacts to continue parallel dependencies.
mvn -T4W test should complete the compilation similarly to mvn -T4 compile
http://docs.codehaus.org/display/MAVENUSER/Weave+mode+characteristics