MDS Select, Autocomplete, Choice, and Number cells - Githubissues

mavenlink / design-system

Mavenlink React Components

https://mavenlink.github.io/design-system

MIT License

2 stars 4 forks source link

MDS Select, Autocomplete, Choice, and Number cells #416

Closed juanca closed 2 years ago

juanca commented 2 years ago

https://www.pivotaltracker.com/story/show/181112961 https://www.pivotaltracker.com/story/show/180679131

Advice for reviewer

I removed <Control> usages so there is a lot of indentation changes.

PR upkeep checklist

[x] Change log entry
[x] Label(s)
[x] Assignee(s)
[x] Deployment URL: https://mavenlink.github.io/design-system/single-choice-cell/
[x] (When ready for review) Reviewer(s)
[x] Green Bigmaven CI check https://github.com/mavenlink/mavenlink/pull/27812
[ ] DevQA on Bigmaven staging (e.g. does the work need to be imported in the internal design system?)

juanca commented 2 years ago

@Bloodyaugust Added classNames API to those components, hah. Also, added a bit of coverage on the Choice component. What do you think?

juanca commented 2 years ago

Previous commits were approved in daisy chained PRs.