MDS (cell) tech debt - Githubissues

mavenlink / design-system

Mavenlink React Components

https://mavenlink.github.io/design-system

MIT License

2 stars 4 forks source link

MDS (cell) tech debt #433

Closed juanca closed 2 years ago

juanca commented 2 years ago

Motivation

Dealing with tech debt. I keep finding new / better ways to do things and now I am standardizing.

Acceptance Criteria

https://www.pivotaltracker.com/story/show/181386764 - Better "useEffect" after first-render https://www.pivotaltracker.com/story/show/181300491 - "Consistent" stylesheet APIs (I am still figuring out the best API) https://www.pivotaltracker.com/story/show/181300473 - Reuse Icons whenever possible https://www.pivotaltracker.com/story/show/181388836 - Show validation message on invalid icon https://www.pivotaltracker.com/story/show/181731606 - The multi-select field has the same initial height as other form controls (i.e. 2rem); the placeholder text has the same styling as the input field https://www.pivotaltracker.com/story/show/181409902 - MDS useValidation hook consistency

PR upkeep checklist

[x] Change log entry
[x] Label(s)
[x] Assignee(s)
[x] Deployment URL: https://mavenlink.github.io/design-system/mds-cell-tech-debt/
[x] (When ready for review) Reviewer(s)
[x] Green Bigmaven CI check https://github.com/mavenlink/mavenlink/pull/28621
[x] DevQA on Bigmaven staging (e.g. does the work need to be imported in the internal design system?)