search

mavlink / MAVSDK-Java

MAVSDK client for Java.
68 stars 40 forks source link

fix: Updated examples/android-client according to the new api #111

Closed jjcetraro closed 1 year ago

JonasVautherin commented 1 year ago

Great, thanks @jjcetraro

@divyanshu1234: would you mind reviewing? Also I invited you as collaborator in the repo, since you do contribute a lot, I think it is well deserved. If you want it of course :wink:

divyanshupundir commented 1 year ago

@JonasVautherin it'll be my pleasure and thanks for the invite.

I'll try to do it by EOD.

divyanshupundir commented 1 year ago

Preoccupied with some work. Will try to do it by tomorrow.

divyanshupundir commented 1 year ago

@jjcetraro Apart from some formatting (indentations) the code looks good. I'll try to run it one my phone by tonight.

divyanshupundir commented 1 year ago

Getting:

java.lang.RuntimeException: Unable to start activity ComponentInfo{io.mavsdk.androidclient/io.mavsdk.androidclient.MapsActivity}: java.lang.SecurityException: getDataNetworkTypeForSubscriber

@jjcetraro This can be easily fixed by adding "com.mapbox.mapboxsdk:mapbox-android-telemetry:6.1.0" dependency. Can you add it?

Everything else works as expected. Please make the changes so that I can merge it after that.

jjcetraro commented 1 year ago

done!

divyanshupundir commented 1 year ago

Great!